Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2335383002: Changed sequence of package_build step (Closed)

Created:
4 years, 3 months ago by miimnk
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Changed sequence of package_build step to be before package_build_for_bisect BUG=645662 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2f0a7c064259dc0e0bf375c2d1771544f5647a1c

Patch Set 1 #

Patch Set 2 : CL categorization: work in progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -44 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 2 chunks +12 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json View 2 chunks +11 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json View 2 chunks +9 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
miimnk
Hi Dave and Prasad. This issue is related to https://bugs.chromium.org/p/chromium/issues/detail?id=645662 Please take a look and ...
4 years, 3 months ago (2016-09-13 21:44:17 UTC) #3
prasadv
lgtm
4 years, 3 months ago (2016-09-13 21:49:47 UTC) #4
dtu
lgtm
4 years, 3 months ago (2016-09-13 21:53:58 UTC) #5
Michael Moss
lgtm
4 years, 3 months ago (2016-09-13 22:04:30 UTC) #11
ghost stip (do not use)
lgtm
4 years, 3 months ago (2016-09-13 22:31:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335383002/1
4 years, 3 months ago (2016-09-15 21:11:53 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/2f0a7c064259dc0e0bf375c2d1771544f5647a1c
4 years, 3 months ago (2016-09-15 21:18:50 UTC) #18
dtu
4 years, 3 months ago (2016-09-19 19:08:40 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2352833002/ by dtu@chromium.org.

The reason for reverting is: Turns out this had an unintended side effect. The
"package build" step sets the "build_archive_url" property, so now the perf
testers are using the wrong build archive.

First failing tests:
https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Per...
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20....

Powered by Google App Engine
This is Rietveld 408576698