Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 2335363003: Temporarily enable scroll anchoring on trunk. (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
index 1aca91b8c5da4bd2ea5e2c856167b8d1cc81060e..ecf35ddeca0d0eb3517608740181f08d27c2d00f 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
@@ -323,8 +323,11 @@ TEST_F('AutoScrollExtensionSettingsWebUITest', 'testAutoScroll', function() {
assertEquals(0, document.body.scrollTop);
this.nextStep();
};
- var scrollToTop = function() {
+ var scrollToOrigin = function() {
+ // Reset both top and left to avoid a scroll anchoring adjustment when the
+ // #dev-controls element is inserted (crbug.com/646977).
document.body.scrollTop = 0;
+ document.body.scrollLeft = 0;
ymalik 2016/09/14 19:54:18 Now that we already know of the bug, should this b
skobes 2016/09/14 19:56:59 Yes it should... see http://crrev.com/2343683002
ymalik 2016/09/14 20:01:43 Ah I see. I was confused because you have it here
this.nextStep();
};
// Test that a) autoscroll works on first page load and b) updating the
@@ -332,7 +335,7 @@ TEST_F('AutoScrollExtensionSettingsWebUITest', 'testAutoScroll', function() {
this.steps = [this.waitForPageLoad,
checkHasScrollbar,
checkIsScrolled,
- scrollToTop,
+ scrollToOrigin,
this.enableDeveloperMode,
checkScrolledToTop,
testDone];
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698