Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2335333003:
Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. (Closed)
DescriptionFix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot.
The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data.
BUG=646509
R=scottmg@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/a8a834050404cd8bda8d54addfd146320d0981e2
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
jam@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was unchecked by jam@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jam@chromium.org
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jam@chromium.org
lgtm https://codereview.chromium.org/2335333003/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2335333003/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:870: "--test-launcher-filter-file=../../testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter", I guess this'll only work with swarming now? Kinda icky.
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2335333003/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2335333003/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:870: "--test-launcher-filter-file=../../testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter", On 2016/09/13 22:35:28, scottmg wrote: > I guess this'll only work with swarming now? Kinda icky. Right. This is how we run content browser tests for site isolation and plznavigate on linux_chromium_rel_ng already.
Message was sent while issue was closed.
Description was changed from ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=645983 ========== to ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=645983 R=scottmg@chromium.org Committed: https://crrev.com/a8a834050404cd8bda8d54addfd146320d0981e2 Cr-Commit-Position: refs/heads/master@{#418421} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a8a834050404cd8bda8d54addfd146320d0981e2 Cr-Commit-Position: refs/heads/master@{#418421}
Message was sent while issue was closed.
Description was changed from ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=645983 R=scottmg@chromium.org Committed: https://crrev.com/a8a834050404cd8bda8d54addfd146320d0981e2 Cr-Commit-Position: refs/heads/master@{#418421} ========== to ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=645983 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a8a834050404cd8bda8d54addfd1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as a8a834050404cd8bda8d54addfd146320d0981e2 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=645983 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a8a834050404cd8bda8d54addfd1... ========== to ========== Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data. BUG=646509 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a8a834050404cd8bda8d54addfd1... ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
