Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 2335323002: [layoutng] Handle box-sizing and correct margin handling for width: auto (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Handle box-sizing and correct margin handling for width: auto Makes sure to only add border/padding for specified values, not keywords, and makes sure to subtract margins when computing the size of width: auto/ fill-available or of height: fill-available. BUG=635619 Committed: https://crrev.com/e951eb5eee11982a32a402745cc19299d4fcb0b0 Cr-Commit-Position: refs/heads/master@{#418405}

Patch Set 1 #

Patch Set 2 : Implement #

Patch Set 3 : ExtendToZoom NOTREACHED #

Total comments: 5

Patch Set 4 : rebased #

Patch Set 5 : missed a spot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -48 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 2 3 4 8 chunks +100 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
cbiesinger
4 years, 3 months ago (2016-09-13 20:43:25 UTC) #3
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode112 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:112: case ExtendToZoom: We know what this is now, ...
4 years, 3 months ago (2016-09-13 21:07:53 UTC) #5
cbiesinger
https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode112 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:112: case ExtendToZoom: On 2016/09/13 21:07:53, mstensho wrote: > We ...
4 years, 3 months ago (2016-09-13 21:14:40 UTC) #6
ikilpatrick
lgtm
4 years, 3 months ago (2016-09-13 21:17:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335323002/60001
4 years, 3 months ago (2016-09-13 21:17:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335323002/80001
4 years, 3 months ago (2016-09-13 21:18:23 UTC) #13
mstensho (USE GERRIT)
https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2335323002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode115 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:115: case DeviceHeight: On 2016/09/13 21:14:40, cbiesinger wrote: > On ...
4 years, 3 months ago (2016-09-13 21:25:42 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-13 23:16:22 UTC) #16
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/e951eb5eee11982a32a402745cc19299d4fcb0b0 Cr-Commit-Position: refs/heads/master@{#418405}
4 years, 3 months ago (2016-09-13 23:19:28 UTC) #18
eae
4 years, 3 months ago (2016-09-15 09:25:15 UTC) #19
Message was sent while issue was closed.
LGTM (post facto)

Powered by Google App Engine
This is Rietveld 408576698