chrome/browser/ui/views/intent_picker_bubble_view.h - Issue 2335313003: Refactor IntentPickerBubbleView::ShowBubble()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/intent_picker_bubble_view.h

Issue 2335313003: Refactor IntentPickerBubbleView::ShowBubble() (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/intent_picker_bubble_view.h

diff --git a/chrome/browser/ui/views/intent_picker_bubble_view.h b/chrome/browser/ui/views/intent_picker_bubble_view.h

index 36c0f475f94c0085f10cffd50f0c631aa88b11f2..e811528ccc8e59d82d0f8423022908a6e546e19e 100644

--- a/chrome/browser/ui/views/intent_picker_bubble_view.h

+++ b/chrome/browser/ui/views/intent_picker_bubble_view.h

@@ -17,7 +17,6 @@

#include "ui/views/controls/button/button.h"

namespace content {

-class NavigationHandle;

class WebContents;

} // namespace content

@@ -61,7 +60,7 @@ class IntentPickerBubbleView : public views::BubbleDialogDelegateView,

base::Callback<void(size_t, arc::ArcNavigationThrottle::CloseReason)>;

~IntentPickerBubbleView() override;

- static void ShowBubble(content::NavigationHandle* handle,

+ static void ShowBubble(content::WebContents* web_contents,

const std::vector<NameAndIcon>& app_info,

const ThrottleCallback& throttle_cb);

static std::unique_ptr<IntentPickerBubbleView> CreateBubbleView(