chrome/browser/chromeos/arc/arc_navigation_throttle.cc - Issue 2335313003: Refactor IntentPickerBubbleView::ShowBubble()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.cc

Issue 2335313003: Refactor IntentPickerBubbleView::ShowBubble() (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_navigation_throttle.cc

diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle.cc b/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

index bb275cc60c8c32b44ed0b2e6f5cf6d563a6aa946..ae3160bfd97acd2d596a08743a6d363d0e8db02a 100644

--- a/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

+++ b/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

@@ -221,7 +221,7 @@ void ArcNavigationThrottle::OnAppIconsReceived(

}

show_intent_picker_callback_.Run(

- navigation_handle(), app_info,

+ navigation_handle()->GetWebContents(), app_info,

base::Bind(&ArcNavigationThrottle::OnIntentPickerClosed,

weak_ptr_factory_.GetWeakPtr(), base::Passed(&handlers)));

}