Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4294)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 2335313002: Always persist histograms from setup.exe. (Closed)
Patch Set: CR grt/bcwhite #4-5 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/persistent_histogram_storage.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 1f4e2688c09bee1445f6fe79163c96ab193587d3..3c192b34d9627e8687fe1c4d11dd84eda6e66af7 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -49,7 +49,7 @@
#include "chrome/installer/setup/install.h"
#include "chrome/installer/setup/install_worker.h"
#include "chrome/installer/setup/installer_crash_reporting.h"
-#include "chrome/installer/setup/installer_metrics.h"
+#include "chrome/installer/setup/persistent_histogram_storage.h"
#include "chrome/installer/setup/setup_constants.h"
#include "chrome/installer/setup/setup_singleton.h"
#include "chrome/installer/setup/setup_util.h"
@@ -1727,7 +1727,7 @@ int WINAPI wWinMain(HINSTANCE instance, HINSTANCE prev_instance,
return installer::CPU_NOT_SUPPORTED;
// Persist histograms so they can be uploaded later.
- installer::BeginPersistentHistogramStorage();
+ installer::PersistentHistogramStorage persistent_histogram_storage;
// The exit manager is in charge of calling the dtors of singletons.
base::AtExitManager exit_manager;
@@ -1762,6 +1762,10 @@ int WINAPI wWinMain(HINSTANCE instance, HINSTANCE prev_instance,
InstallerState installer_state;
installer_state.Initialize(cmd_line, prefs, original_state);
+ persistent_histogram_storage.set_storage_dir(
+ installer::PersistentHistogramStorage::GetReportedStorageDir(
+ installer_state.target_path()));
+
installer::ConfigureCrashReporting(installer_state);
installer::SetInitialCrashKeys(installer_state);
installer::SetCrashKeysFromCommandLine(cmd_line);
@@ -1911,8 +1915,6 @@ int WINAPI wWinMain(HINSTANCE instance, HINSTANCE prev_instance,
return_code = InstallUtil::GetInstallReturnCode(install_status);
}
- installer::EndPersistentHistogramStorage(installer_state.target_path(),
- system_install);
VLOG(1) << "Installation complete, returning: " << return_code;
return return_code;
« no previous file with comments | « chrome/installer/setup/persistent_histogram_storage.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698