Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23353002: Fix receiver refining optimization in the presence of null: any Object method can be called on the … (Closed)

Created:
7 years, 4 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix receiver refining optimization in the presence of null: any Object method can be called on the null object.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/function_set.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/interceptors.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 3 chunks +10 lines, -0 lines 0 comments Download
A tests/language/refine_receiver_null_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 4 months ago (2013-08-20 13:32:12 UTC) #1
karlklose
LGTM.
7 years, 4 months ago (2013-08-21 07:28:24 UTC) #2
ngeoffray
7 years, 4 months ago (2013-08-21 07:30:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698