ShouldDisplayOverFullscreen implementation

chrome/browser/extensions/api/notifications/notifications_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 13 matching lines @@
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/notifications/notifier_state_tracker.h"
 #include "chrome/browser/notifications/notifier_state_tracker_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/notifications/notification_style.h"
 #include "components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.h"
 #include "components/keyed_service/core/keyed_service_shutdown_notifier.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
+#include "extensions/browser/app_window/app_window.h"
+#include "extensions/browser/app_window/app_window_registry.h"
+#include "extensions/browser/app_window/native_app_window.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_system_provider.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/features/feature.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/layout.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_operations.h"
@@ skipping 92 matching lines @@
 };
 
 class NotificationsApiDelegate : public NotificationDelegate {
  public:
   NotificationsApiDelegate(ChromeAsyncExtensionFunction* api_function,
                            Profile* profile,
                            const std::string& extension_id,
                            const std::string& id)
       : api_function_(api_function),
         event_router_(EventRouter::Get(profile)),
+        profile_(profile),

[dewittj, 2016/09/14 21:06:51]

Don't store profile, call GetProfile()

[bmalcolm, 2016/09/14 21:56:24]

GetProfile isn't available in NotificationsApiDelegate or NotificationDelegate -
it is available in NotificationsApiFunction, which is passing it in to the
NotificationsApiDelegate c'tor. I don't see a way to not store it unless I store
the AppWindowRegistry in the c'tor instead. 

Am I missing something?

[dewittj, 2016/09/14 23:09:46]

You're right.  One way to do it is to call api_function_->GetProfile()

But I'm beginning to worry about lifetimes.  In particular, Profile* can be
destroyed if the profile is incognito.  Holding a bare pointer could cause
crashes if the profile is destroyed.

Looks like tons of other notification delegates hold on to Profile* so it's
probably fine.

         extension_id_(extension_id),
         id_(id),
         scoped_id_(CreateScopedIdentifier(extension_id, id)) {
     DCHECK(api_function_);
     shutdown_notifier_subscription_ =
         ShutdownNotifierFactory::GetInstance()->Get(profile)->Subscribe(
             base::Bind(&NotificationsApiDelegate::Shutdown,
                        base::Unretained(this)));
   }
 
@@ skipping 25 matching lines @@
   void ButtonClick(int index) override {
     std::unique_ptr<base::ListValue> args(CreateBaseEventArgs());
     args->AppendInteger(index);
     SendEvent(events::NOTIFICATIONS_ON_BUTTON_CLICKED,
               notifications::OnButtonClicked::kEventName,
               EventRouter::USER_GESTURE_ENABLED, std::move(args));
   }
 
   std::string id() const override { return scoped_id_; }
 
+  // Should only display when fullscreen if this app is the source of the
+  // fullscreen window.
+  bool ShouldDisplayOverFullscreen() const override {
+    AppWindowRegistry::AppWindowList windows =
+        AppWindowRegistry::Get(profile_)->GetAppWindowsForApp(extension_id_);
+    for (const auto& window : windows) {
+      // Window must be fullscreen and visible
+      if (window->IsFullscreen() && window->GetBaseWindow()->IsActive()) {

[dewittj, 2016/09/14 21:06:51]

nit: single line if blocks should not have braces

[bmalcolm, 2016/09/14 21:56:24]

Done.

+        return true;
+      }
+    }
+    return false;
+  }
+
  private:
   ~NotificationsApiDelegate() override {}
 
   void SendEvent(events::HistogramValue histogram_value,
                  const std::string& name,
                  EventRouter::UserGestureState user_gesture,
                  std::unique_ptr<base::ListValue> args) {
     if (!event_router_)
       return;
 
@@ skipping 14 matching lines @@
     return args;
   }
 
   scoped_refptr<ChromeAsyncExtensionFunction> api_function_;
 
   // Since this class is refcounted it may outlive the profile.  We listen for
   // profile-keyed service shutdown events and reset to nullptr at that time,
   // so make sure to check for a valid pointer before use.
   EventRouter* event_router_;
 
+  Profile* profile_;
   const std::string extension_id_;
   const std::string id_;
   const std::string scoped_id_;
 
   std::unique_ptr<KeyedServiceShutdownNotifier::Subscription>
       shutdown_notifier_subscription_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationsApiDelegate);
 };
 
@@ skipping 487 matching lines @@
           : api::notifications::PERMISSION_LEVEL_DENIED;
 
   SetResult(base::MakeUnique<base::StringValue>(
       api::notifications::ToString(result)));
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions