Push CompositorFilterOperations creation out of GraphicsLayer

third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 17 matching lines @@
 
 #include "platform/PlatformExport.h"
 #include "platform/graphics/ColorSpace.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 
 class SkImageFilter;
 class SkPicture;
 
 namespace blink {
 
-class AffineTransform;
 class BoxReflection;
 class CompositorFilterOperations;
 class FilterEffect;
 class FilterOperations;
-class Image;
 
 namespace SkiaImageFilterBuilder {
 
 PLATFORM_EXPORT sk_sp<SkImageFilter> build(FilterEffect*, ColorSpace, bool requiresPMColorValidation = true);
-PLATFORM_EXPORT void buildFilterOperations(const FilterOperations&, CompositorFilterOperations*);
-PLATFORM_EXPORT sk_sp<SkImageFilter> buildTransform(const AffineTransform&, sk_sp<SkImageFilter> input);
+PLATFORM_EXPORT CompositorFilterOperations buildFilterOperations(const FilterOperations&);

[Stephen White, 2016/09/16 14:05:59]

Does this mean we'll be incurring the copy constructor of
CompositorFilterOperations, and transitively, cc::FilterOperations and
std::vector<FilterOperation>? The only move constructor for cc::FilterOperations
I could find takes a std::vector<FilterOperation>&&, not a
cc::FilterOperations&&, but maybe I'm reading things incorrectly.

[fs, 2016/09/16 14:54:38]

I could be wrong, but I think this would RVO. Empirical testing (==reading the
generated code) suggests there's no undue copying going on (that didn't go on
before this CL.)

 
 PLATFORM_EXPORT sk_sp<SkImageFilter> transformColorSpace(
     sk_sp<SkImageFilter> input, ColorSpace srcColorSpace, ColorSpace dstColorSpace);
 
 PLATFORM_EXPORT void buildSourceGraphic(FilterEffect*, sk_sp<SkPicture>);
 
 PLATFORM_EXPORT sk_sp<SkImageFilter> buildBoxReflectFilter(const BoxReflection&, sk_sp<SkImageFilter> input);
 
 } // namespace SkiaImageFilterBuilder
 } // namespace blink
 
 #endif