Split fsdk_mgr files apart.

Split fsdk_mgr files apart.

This CL separates the CPDFDoc_Environment, CPDFSDK_Document and CPDFSDK_PageView
classes into their own h and cpp files.

Committed: https://pdfium.googlesource.com/pdfium/+/f34518bd1379289659b4c050d140690ba8f8b8aa

[dsinclair, 2016-09-13 16:12:45]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 16:12:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 16:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 16:14:46]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/724)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[dsinclair, 2016-09-13 17:22:24]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-13 17:23:17]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-09-13 17:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 17:36:39]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-13 17:48:33]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-09-13 17:48:34]

PTAL.

[Tom Sepez, 2016-09-13 18:32:02]

lgtm

https://codereview.chromium.org/2335243002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2335243002/diff/40001/BUILD.gn#newcode68
BUILD.gn:68: "fpdfsdk/cpdfdoc_environment.cpp",
Methinks this is actually a cpdfsdk_environment.cpp file providing a
CPDFSDK_Environment, and that there is no such thing as CPDFDoc_Environment,
given that grep shows it is only used in fpdfsdk/.  What good are pointless
naming conventions if we aren't going to rigidly adhere to them?

But that's a struggle for another day.

[dsinclair, 2016-09-13 18:35:15]

https://codereview.chromium.org/2335243002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2335243002/diff/40001/BUILD.gn#newcode68
BUILD.gn:68: "fpdfsdk/cpdfdoc_environment.cpp",
On 2016/09/13 18:32:02, Tom Sepez wrote:
> Methinks this is actually a cpdfsdk_environment.cpp file providing a
> CPDFSDK_Environment, and that there is no such thing as CPDFDoc_Environment,
> given that grep shows it is only used in fpdfsdk/.  What good are pointless
> naming conventions if we aren't going to rigidly adhere to them?
> 
> But that's a struggle for another day. 


Yea, will rename in a followup. Didn't want to make this CL any worse, heh.

[dsinclair, 2016-09-13 18:35:27]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:35:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:03:51]

Description was changed from

==========
Split fsdk_mgr files apart.

This CL separates the CPDFDoc_Environment, CPDFSDK_Document and CPDFSDK_PageView
classes into their own h and cpp files.
==========

to

==========
Split fsdk_mgr files apart.

This CL separates the CPDFDoc_Environment, CPDFSDK_Document and CPDFSDK_PageView
classes into their own h and cpp files.

Committed:
https://pdfium.googlesource.com/pdfium/+/f34518bd1379289659b4c050d140690ba8f8...
==========

[commit-bot: I haz the power, 2016-09-13 19:03:52]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f34518bd1379289659b4c050d140690ba8f8...