Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 2335223003: LogDog: Update web code, stream/query with auth. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Update web code, stream/query with auth. Add facilities to display web viewer status, retry on missing stream, and retry with authentication when available. Authentication occurs as an optional asynchronous event. This wires that event up to a retry hook that will retry the stream query and/or stream fetching when previous attempts failed for authentication reasons. If authentication isn't necessary, it will not be used and the first attempt will succeed. Additionally, update the web query code to move more logic out of the core Polymer area and into standalone objects. The plan is to move those objects over to TypeScript and add unit tests for their behaviors. This should be much easier now that the objects are testable without a full Polymer setup. BUG=chromium:645692 TEST=local - Streamed logs from protected and non-protected projects. - Successfully logged in after failure and loaded logs. - Successfully queried for logs where the query required authentication. - Successfully loaded multiple log streams. Committed: https://github.com/luci/luci-go/commit/500fb4485ac91f2ba636ed03e492123aa64b8a3f

Patch Set 1 #

Patch Set 2 : Handle total failures of streams, optimize multi-stream loading. #

Patch Set 3 : Fix background page loading. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+779 lines, -263 lines) Patch
M web/apps/logdog-app/elements/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M web/apps/logdog-view/elements/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M web/apps/logdog-view/elements/logdog-view/logdog-view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M web/bower.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M web/inc/auth/auth-signin.html View 1 2 2 chunks +34 lines, -1 line 0 comments Download
M web/inc/logdog-stream-view/logdog-stream-fetcher.html View 1 5 chunks +20 lines, -7 lines 0 comments Download
M web/inc/logdog-stream-view/logdog-stream-query.html View 3 chunks +5 lines, -1 line 0 comments Download
M web/inc/logdog-stream-view/logdog-stream-view.html View 1 2 13 chunks +659 lines, -250 lines 0 comments Download
A web/inc/logdog-stream/logdog-error.html View 1 chunk +32 lines, -0 lines 0 comments Download
M web/inc/logdog-stream/logdog-stream.html View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
dnj
PTAL!
4 years, 3 months ago (2016-09-13 21:12:15 UTC) #2
dnj
4 years, 3 months ago (2016-09-16 23:44:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
500fb4485ac91f2ba636ed03e492123aa64b8a3f.

Powered by Google App Engine
This is Rietveld 408576698