Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 2335213004: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
index e84f06938405fbb412b435626c8886cb1228e17c..99c1c8cc37fa2df5d5b124e753a3ae0c33d391a6 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
@@ -216,14 +216,16 @@ void FileManagerPrivateInternalGetFileTasksFunction::OnFileTasksListed(
SendResponse(true);
}
-bool FileManagerPrivateInternalSetDefaultTaskFunction::RunSync() {
+ExtensionFunction::ResponseAction
+FileManagerPrivateInternalSetDefaultTaskFunction::Run() {
using extensions::api::file_manager_private_internal::SetDefaultTask::Params;
const std::unique_ptr<Params> params(Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
+ Profile* profile = Profile::FromBrowserContext(browser_context());
const scoped_refptr<storage::FileSystemContext> file_system_context =
file_manager::util::GetFileSystemContextForRenderFrameHost(
- GetProfile(), render_frame_host());
+ profile, render_frame_host());
const std::set<std::string> suffixes =
GetUniqueSuffixes(params->urls, file_system_context.get());
@@ -237,13 +239,13 @@ bool FileManagerPrivateInternalSetDefaultTaskFunction::RunSync() {
// TODO(gspencer): Fix file manager so that it never tries to set default in
// cases where extensionless local files are part of the selection.
if (suffixes.empty() && mime_types.empty()) {
- SetResult(base::MakeUnique<base::FundamentalValue>(true));
- return true;
+ return RespondNow(
+ OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
}
file_manager::file_tasks::UpdateDefaultTask(
- GetProfile()->GetPrefs(), params->task_id, suffixes, mime_types);
- return true;
+ profile->GetPrefs(), params->task_id, suffixes, mime_types);
+ return RespondNow(NoArguments());
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698