third_party/WebKit/Source/core/frame/Window.idl - Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)

Patch Set: Polishing + naming revisited Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Window.idl

diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl

index fb6de0a9bd4f0e3a0695a596462a11e9b742af3d..ff06d53d14e6dfccf471d334dbcc4cf794727055 100644

--- a/third_party/WebKit/Source/core/frame/Window.idl

+++ b/third_party/WebKit/Source/core/frame/Window.idl

@@ -36,7 +36,8 @@

// FIXME: The spec uses the WindowProxy type for this and many other attributes.

[Unforgeable, DoNotCheckSecurity] readonly attribute Window window;

[Replaceable, DoNotCheckSecurity] readonly attribute Window self;

- [Unforgeable] readonly attribute Document document;

+ [Unforgeable, CachedAccessor] readonly attribute Document document;

attribute DOMString name;

[PutForwards=href, Unforgeable, DoNotCheckSecurity] readonly attribute Location location;

readonly attribute History history;