Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp |
| diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp |
| index 6e8dbc7ca9c56d4b19ff438aa396fe8e1ff3c2c9..8128ef60ff7b9bbebe4e562f7b4ffd97bf058c66 100644 |
| --- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp |
| +++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp |
| @@ -42,6 +42,7 @@ |
| #include "bindings/core/v8/V8Initializer.h" |
| #include "bindings/core/v8/V8ObjectConstructor.h" |
| #include "bindings/core/v8/V8PagePopupControllerBinding.h" |
| +#include "bindings/core/v8/V8PrivateProperty.h" |
| #include "bindings/core/v8/V8Window.h" |
| #include "core/frame/LocalFrame.h" |
| #include "core/frame/csp/ContentSecurityPolicy.h" |
| @@ -410,9 +411,9 @@ void WindowProxy::updateDocumentProperty() |
| checkDocumentWrapper(m_document.newLocal(m_isolate), frame->document()); |
| ASSERT(documentWrapper->IsObject()); |
| - // TODO(jochen): Don't replace the accessor with a data value. We need a way to tell v8 that the accessor's return value won't change after this point. |
| - if (!v8CallBoolean(context->Global()->ForceSet(context, v8AtomicString(m_isolate, "document"), documentWrapper, static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete)))) |
| - return; |
| + |
| + // Update cache. |
|
haraken
2016/09/20 14:15:03
Update cached accessor.
|
| + CHECK(V8PrivateProperty::getWindowDocument(m_isolate).set(context, context->Global(), documentWrapper)); |
| } |
| void WindowProxy::updateActivityLogger() |