Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 2335203006: Add [CachedAccessor] attribute to cache (almost) constant accessors (window.document). (Closed)
Patch Set: Pre-review nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 {% set has_prepare_prototype_and_interface_object = 3 {% set has_prepare_prototype_and_interface_object =
4 unscopeables or has_conditional_attributes_on_prototype or 4 unscopeables or has_conditional_attributes_on_prototype or
5 methods | conditionally_exposed(is_partial) %} 5 methods | conditionally_exposed(is_partial) %}
6 {% set prepare_prototype_and_interface_object_func = 6 {% set prepare_prototype_and_interface_object_func =
7 '%s::preparePrototypeAndInterfaceObject' % v8_class 7 '%s::preparePrototypeAndInterfaceObject' % v8_class
8 if has_prepare_prototype_and_interface_object 8 if has_prepare_prototype_and_interface_object
9 else 'nullptr' %} 9 else 'nullptr' %}
10 10
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 {% else %} 690 {% else %}
691 {% set getter_callback_for_main_world = '0' %} 691 {% set getter_callback_for_main_world = '0' %}
692 {% set setter_callback_for_main_world = '0' %} 692 {% set setter_callback_for_main_world = '0' %}
693 {% endif %} 693 {% endif %}
694 {% set property_attribute = 694 {% set property_attribute =
695 'static_cast<v8::PropertyAttribute>(%s)' % 695 'static_cast<v8::PropertyAttribute>(%s)' %
696 ' | '.join(method.property_attributes or ['v8::None']) %} 696 ' | '.join(method.property_attributes or ['v8::None']) %}
697 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %} 697 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %}
698 {% set holder_check = 'V8DOMConfiguration::CheckHolder' %} 698 {% set holder_check = 'V8DOMConfiguration::CheckHolder' %}
699 const V8DOMConfiguration::AttributeConfiguration {{method.name}}OriginSafeAttrib uteConfiguration = { 699 const V8DOMConfiguration::AttributeConfiguration {{method.name}}OriginSafeAttrib uteConfiguration = {
700 "{{method.name}}", {{getter_callback}}, {{setter_callback}}, {{getter_callba ck_for_main_world}}, {{setter_callback_for_main_world}}, nullptr, &{{v8_class}}: :wrapperTypeInfo, v8::ALL_CAN_READ, {{property_attribute}}, {{only_exposed_to_pr ivate_script}}, {{property_location(method)}}, {{holder_check}}, 700 "{{method.name}}", {{getter_callback}}, {{setter_callback}}, {{getter_callba ck_for_main_world}}, {{setter_callback_for_main_world}}, nullptr, 0, &{{v8_class }}::wrapperTypeInfo, v8::ALL_CAN_READ, {{property_attribute}}, {{only_exposed_to _private_script}}, {{property_location(method)}}, {{holder_check}},
jochen (gone - plz use gerrit) 2016/09/15 08:20:51 nullptr?
Alfonso 2016/09/16 14:21:48 Done.
701 }; 701 };
702 V8DOMConfiguration::installAttribute(isolate, world, {{instance_template}}, {{pr ototype_template}}, {{method.name}}OriginSafeAttributeConfiguration); 702 V8DOMConfiguration::installAttribute(isolate, world, {{instance_template}}, {{pr ototype_template}}, {{method.name}}OriginSafeAttributeConfiguration);
703 {%- endmacro %} 703 {%- endmacro %}
704 704
705 705
706 {##############################################################################} 706 {##############################################################################}
707 {% macro install_indexed_property_handler(target) %} 707 {% macro install_indexed_property_handler(target) %}
708 {% set indexed_property_getter_callback = 708 {% set indexed_property_getter_callback =
709 '%sV8Internal::indexedPropertyGetterCallback' % cpp_class %} 709 '%sV8Internal::indexedPropertyGetterCallback' % cpp_class %}
710 {% set indexed_property_setter_callback = 710 {% set indexed_property_setter_callback =
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 985
986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
988 { 988 {
989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
990 } 990 }
991 991
992 {% endfor %} 992 {% endfor %}
993 {% endif %} 993 {% endif %}
994 {% endblock %} 994 {% endblock %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698