Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2335203004: Android GN scripts: distingush directories for data and binaries. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : derp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -68 lines) Patch
M infra/bots/recipe_modules/flavor/gn_android_flavor.py View 1 3 chunks +21 lines, -17 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android.json View 1 26 chunks +51 lines, -51 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 3 months ago (2016-09-14 01:19:29 UTC) #4
borenet
LGTM
4 years, 3 months ago (2016-09-14 11:19:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335203004/20001
4 years, 3 months ago (2016-09-14 11:51:19 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:33:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/53c02e015664712649056b18b3d4da596b491186

Powered by Google App Engine
This is Rietveld 408576698