Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 2335203003: Add metrics to keep track of the tab activate/deactivate cycle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
index 4253caaaf19e16b453b294155a9835eaf6e037a3..0c2bdd72e09ee4e395b75fcc27c9067980f743c1 100644
--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
@@ -433,7 +433,8 @@ SkColor BrowserTabStripController::GetToolbarTopSeparatorColor() const {
////////////////////////////////////////////////////////////////////////////////
// BrowserTabStripController, TabStripModelObserver implementation:
-void BrowserTabStripController::TabInsertedAt(WebContents* contents,
+void BrowserTabStripController::TabInsertedAt(TabStripModel* tab_strip_model,
+ WebContents* contents,
int model_index,
bool is_active) {
DCHECK(contents);
@@ -486,8 +487,10 @@ void BrowserTabStripController::TabReplacedAt(TabStripModel* tab_strip_model,
SetTabDataAt(new_contents, model_index);
}
-void BrowserTabStripController::TabPinnedStateChanged(WebContents* contents,
- int model_index) {
+void BrowserTabStripController::TabPinnedStateChanged(
+ TabStripModel* tab_strip_model,
+ WebContents* contents,
+ int model_index) {
SetTabDataAt(contents, model_index);
}

Powered by Google App Engine
This is Rietveld 408576698