Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc

Issue 2335203003: Add metrics to keep track of the tab activate/deactivate cycle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
diff --git a/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc b/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
index 47bae070c5301cc48fab3f265493b1da8974138d..820ab2c68f0b103bfc527273895225e2d085daa2 100644
--- a/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
+++ b/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
@@ -198,14 +198,6 @@ class TabScrubberTest : public InProcessBrowserTest,
}
// TabStripModelObserver overrides.
- void TabInsertedAt(content::WebContents* contents,
Patrick Monette 2016/09/16 00:14:01 Cleaned up this code while I was here. An empty i
- int index,
- bool foreground) override {}
- void TabClosingAt(TabStripModel* tab_strip_model,
- content::WebContents* contents,
- int index) override {}
- void TabDetachedAt(content::WebContents* contents, int index) override {}
- void TabDeactivated(content::WebContents* contents) override {}
void ActiveTabChanged(content::WebContents* old_contents,
content::WebContents* new_contents,
int index,
@@ -215,24 +207,6 @@ class TabScrubberTest : public InProcessBrowserTest,
quit_closure_.Run();
}
- void TabSelectionChanged(TabStripModel* tab_strip_model,
- const ui::ListSelectionModel& old_model) override {}
- void TabMoved(content::WebContents* contents,
- int from_index,
- int to_index) override {}
- void TabChangedAt(content::WebContents* contents,
- int index,
- TabChangeType change_type) override {}
- void TabReplacedAt(TabStripModel* tab_strip_model,
- content::WebContents* old_contents,
- content::WebContents* new_contents,
- int index) override {}
- void TabPinnedStateChanged(content::WebContents* contents,
- int index) override {}
- void TabBlockedStateChanged(content::WebContents* contents,
- int index) override {}
- void TabStripEmpty() override {}
-
// History of tab activation. Scrub() resets it.
std::vector<int> activation_order_;

Powered by Google App Engine
This is Rietveld 408576698