Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3477)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_unittest.cc

Issue 2335203003: Add metrics to keep track of the tab activate/deactivate cycle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/tab_strip_model_unittest.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
index 9d54fec7ef8534f2468b746f6a5be7be61d502b2..fde06e6f7f16f974187fead1e65fe0eba03d39f2 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
@@ -149,7 +149,8 @@ class TabBlockedStateTestBrowser
private:
// TabStripModelObserver
- void TabInsertedAt(WebContents* contents,
+ void TabInsertedAt(TabStripModel* tab_strip_model,
+ WebContents* contents,
int index,
bool foreground) override {
web_modal::WebContentsModalDialogManager* manager =
@@ -401,7 +402,9 @@ class MockTabStripModelObserver : public TabStripModelObserver {
s.src_contents = old_contents;
states_.push_back(s);
}
- void TabPinnedStateChanged(WebContents* contents, int index) override {
+ void TabPinnedStateChanged(TabStripModel* tab_strip_model,
+ WebContents* contents,
+ int index) override {
states_.push_back(State(contents, index, PINNED));
}
void TabStripEmpty() override { empty_ = true; }

Powered by Google App Engine
This is Rietveld 408576698