Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2335203003: Add metrics to keep track of the tab activate/deactivate cycle (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index b9b1da9bc8b7638dc8c5fa3830d302a21e4ce19a..f1ab7844e8b53900c38c8597a1eabfdf3c9ecf68 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -912,7 +912,8 @@ WebContents* Browser::OpenURL(const OpenURLParams& params) {
///////////////////////////////////////////////////////////////////////////////
// Browser, TabStripModelObserver implementation:
-void Browser::TabInsertedAt(WebContents* contents,
+void Browser::TabInsertedAt(TabStripModel* tab_strip_model,
+ WebContents* contents,
int index,
bool foreground) {
SetAsDelegate(contents, true);
@@ -1085,8 +1086,7 @@ void Browser::TabReplacedAt(TabStripModel* tab_strip_model,
SessionServiceFactory::GetForProfile(profile_);
if (session_service)
session_service->TabClosing(old_contents);
- TabInsertedAt(new_contents,
- index,
+ TabInsertedAt(tab_strip_model, new_contents, index,
(index == tab_strip_model_->active_index()));
if (!new_contents->GetController().IsInitialBlankNavigation()) {
@@ -1104,7 +1104,9 @@ void Browser::TabReplacedAt(TabStripModel* tab_strip_model,
}
}
-void Browser::TabPinnedStateChanged(WebContents* contents, int index) {
+void Browser::TabPinnedStateChanged(TabStripModel* tab_strip_model,
+ WebContents* contents,
+ int index) {
SessionService* session_service =
SessionServiceFactory::GetForProfileIfExisting(profile());
if (session_service) {

Powered by Google App Engine
This is Rietveld 408576698