Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 23352004: Add a trap_on_abort flag (Closed)

Created:
7 years, 4 months ago by oliv
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add a trap_on_abort flag By setting this flag assertions behind --debug-code will trigger a breakpoint instead of a call into Abort. This eases debugging, as the call site is less cluttered and the backtrace starts where it should. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16319

Patch Set 1 : fix #

Total comments: 2

Patch Set 2 : address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 4 months ago (2013-08-22 08:25:48 UTC) #1
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/23352004/diff/2001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/23352004/diff/2001/src/arm/macro-assembler-arm.cc#newcode2852 src/arm/macro-assembler-arm.cc:2852: DebugBreak(); You probably want to use ...
7 years, 4 months ago (2013-08-22 13:36:16 UTC) #2
oliv
7 years, 4 months ago (2013-08-26 11:23:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698