Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Issue 2335193006: [Sync] Fix namespaces for the sync_bookmarks component. (Closed)

Created:
4 years, 3 months ago by maxbogue
Modified:
4 years, 3 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix namespaces for the sync_bookmarks component. Things within a component should have a namespace that matches its name. BUG=646685 Committed: https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b Cr-Commit-Position: refs/heads/master@{#418581}

Patch Set 1 #

Patch Set 2 : This is what I get for de-linting. #

Messages

Total messages: 16 (11 generated)
maxbogue
Sky, PTAL!
4 years, 3 months ago (2016-09-14 16:09:26 UTC) #10
skym
lgtm
4 years, 3 months ago (2016-09-14 16:11:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335193006/20001
4 years, 3 months ago (2016-09-14 16:19:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 16:24:28 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:28:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b
Cr-Commit-Position: refs/heads/master@{#418581}

Powered by Google App Engine
This is Rietveld 408576698