third_party/WebKit/Source/wtf/text/StringBuilder.h - Issue 2335193005: Release the buffer in StringBuilder::toString() and toAtomicString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuilder.h

Issue 2335193005: Release the buffer in StringBuilder::toString() and toAtomicString(). (Closed)

Patch Set: Make m_string and m_buffer exclusive to each other. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringBuilder.h

diff --git a/third_party/WebKit/Source/wtf/text/StringBuilder.h b/third_party/WebKit/Source/wtf/text/StringBuilder.h

index 3b2c36556851c9456079033f7f69041c032140f4..3cc8108b8a3d236e2d9e807d3116343f9d36f34f 100644

--- a/third_party/WebKit/Source/wtf/text/StringBuilder.h

+++ b/third_party/WebKit/Source/wtf/text/StringBuilder.h

@@ -116,7 +116,6 @@ public:

return;

}

ensureBuffer16(1);

- m_string = String();

m_buffer16->append(c);

++m_length;

}

@@ -128,7 +127,6 @@ public:

return;

}

ensureBuffer8(1);

- m_string = String();

m_buffer8->append(c);

++m_length;

}

@@ -226,7 +224,7 @@ private:

void createBuffer8(unsigned addedSize);

void createBuffer16(unsigned addedSize);

+ void clearBuffer();

bool hasBuffer() const { return m_buffer; }

String m_string;