Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2335193003: Revert of Do not let text-size-adjust override accessibility font settings (Closed)

Created:
4 years, 3 months ago by aberent
Modified:
4 years, 3 months ago
Reviewers:
pdr., skobes
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not let text-size-adjust override accessibility font settings (patchset #2 id:20001 of https://codereview.chromium.org/2329733002/ ) Reason for revert: Broke ContextualSearchManagerTest#testChainedSearchCreatesNewContent and ContextualSearchManagerTest#testChainedTapsRemovedFromHistory BUG=646342 Original issue's description: > Do not let text-size-adjust override accessibility font settings > > The text autosizer is used for both making desktop pages more legible > on mobile, and for applying the accessibility font scale factor. When > text-size-adjust support was added, pages were able to override the > accessibility setting in addition to the autosizing multiplier. > > This patch ensures accessibility font scale settings are respected even > with text-size-adjust. A followup bug has been filed (crbug.com/645717) > for moving the accessibility font scale factor out of the autosizer. > > This patch also re-enables support for text-size-adjust which was > disabled temporarily due to breaking accessibility settings. > > BUG=645269 > > Committed: https://crrev.com/eccac1fd6db85731fb95b11915fc2197a6ceb0c3 > Cr-Commit-Position: refs/heads/master@{#418173} TBR=skobes@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645269 Committed: https://crrev.com/3ec856cdfb31f023a832547f4f702858e9b8a903 Cr-Commit-Position: refs/heads/master@{#418278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -152 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 4 chunks +19 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 6 chunks +5 lines, -125 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aberent
Created Revert of Do not let text-size-adjust override accessibility font settings
4 years, 3 months ago (2016-09-13 17:05:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335193003/1
4 years, 3 months ago (2016-09-13 17:05:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 17:06:13 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:07:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ec856cdfb31f023a832547f4f702858e9b8a903
Cr-Commit-Position: refs/heads/master@{#418278}

Powered by Google App Engine
This is Rietveld 408576698