[wasm] Move the wasm-module-runner from test/cctest to test/common

[wasm] Move the wasm-module-runner from test/cctest to test/common

The wasm-module-runner is used both in cctests and in fuzzers. As
discussed offline, it is weird to include cctest header files in
fuzzers, so I introduce a new test/common directory which contains the
common files.

R=titzer@chromium.org, jochen@chromium.org

Committed: https://crrev.com/cc7926d672fd20660123eccf082c31356d8ac0f1
Cr-Commit-Position: refs/heads/master@{#39411}

[ahaas, 2016-09-13 13:54:33]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 13:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 13:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:59:14]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[ahaas, 2016-09-13 14:03:18]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 14:03:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 14:52:13]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12579)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[titzer, 2016-09-13 16:32:43]

lgtm

https://codereview.chromium.org/2335193002/diff/20001/test/cctest/wasm/wasm-m...
File test/cctest/wasm/wasm-module-runner.h (left):

https://codereview.chromium.org/2335193002/diff/20001/test/cctest/wasm/wasm-m...
test/cctest/wasm/wasm-module-runner.h:6: #define V8_WASM_MODULE_RUNNER_H_
How about also moving test-signatures.h?

[jochen (gone - plz use gerrit), 2016-09-14 08:29:12]

lgtm

[jochen (gone - plz use gerrit), 2016-09-14 08:30:28]

ah, wait, test/cctest/BUILD.gn gets it's sources list from cctest.gyp, but it
should just depend on the new target you introduced in the top-level BUILD.gn
file, no?

can you add a new target for gyp as well, so we get that dependency right?

[ahaas, 2016-09-14 09:46:36]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-14 09:47:18]

On 2016/09/14 at 08:30:28, jochen wrote:
> ah, wait, test/cctest/BUILD.gn gets it's sources list from cctest.gyp, but it
should just depend on the new target you introduced in the top-level BUILD.gn
file, no?
> 
> can you add a new target for gyp as well, so we get that dependency right?

Done. If you use GN, then files are compiled only once.

[jochen (gone - plz use gerrit), 2016-09-14 10:03:55]

lgtm

[commit-bot: I haz the power, 2016-09-14 10:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 10:19:47]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-14 10:29:04]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-14 10:29:05]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2335193002/#ps40001
(title: "Files should be compiled exactly once in a GN build.")

[commit-bot: I haz the power, 2016-09-14 10:29:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 10:31:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 10:32:02]

Description was changed from

==========
[wasm] Move the wasm-module-runner from test/cctest to test/common

The wasm-module-runner is used both in cctests and in fuzzers. As
discussed offline, it is weird to include cctest header files in
fuzzers, so I introduce a new test/common directory which contains the
common files.

R=titzer@chromium.org, jochen@chromium.org
==========

to

==========
[wasm] Move the wasm-module-runner from test/cctest to test/common

The wasm-module-runner is used both in cctests and in fuzzers. As
discussed offline, it is weird to include cctest header files in
fuzzers, so I introduce a new test/common directory which contains the
common files.

R=titzer@chromium.org, jochen@chromium.org

Committed: https://crrev.com/cc7926d672fd20660123eccf082c31356d8ac0f1
Cr-Commit-Position: refs/heads/master@{#39411}
==========

[commit-bot: I haz the power, 2016-09-14 10:32:03]

Patchset 3 (id:??) landed as
https://crrev.com/cc7926d672fd20660123eccf082c31356d8ac0f1
Cr-Commit-Position: refs/heads/master@{#39411}