Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2335173002: Forbid ImageDownloaderImpl from accessing RenderThread instance after message loop shutdown. (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Forbid ImageDownloaderImpl from accessing RenderThread instance after message loop shutdown. This CL fixes the crash caused by following possible scenario: - the message loop is shutdown. - during its destructor it calls connection error on ImageDownloaderImpl. - the strong binding of ImageDownloaderImpl causes it to be destructed. - the destructor calls RenderThread::Get()->RemoveObserver(this), which is not valid any more. BUG=640999 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2286603002 Cr-Commit-Position: refs/heads/master@{#414985} (cherry picked from commit d2ac649bc631233f4355860a011d3d30f985bb67) Committed: https://chromium.googlesource.com/chromium/src/+/a64d2294bbe77cf839715bfefa407d61147e79d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/image_downloader/image_downloader_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
4 years, 3 months ago (2016-09-13 10:19:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a64d2294bbe77cf839715bfefa407d61147e79d6.

Powered by Google App Engine
This is Rietveld 408576698