PlzNavigate: support the WebRequest API

PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1e5574e9aa99ff49474912f87c1bf2b3924bd24d
Cr-Commit-Position: refs/heads/master@{#421846}

[clamy, 2016-09-13 13:23:58]

Description was changed from

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
==========

to

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-09-13 13:37:19]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 13:37:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 13:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:54:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[clamy, 2016-09-14 13:35:06]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:05:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[clamy, 2016-09-15 15:19:10]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 15:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:05:15]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[clamy, 2016-09-16 12:43:44]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 12:43:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 13:45:33]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-09-16 13:47:34]

Description was changed from

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-09-16 13:47:34]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org, rdevlin.cronin@chromium.org

[clamy, 2016-09-16 13:48:44]

@rdcronin, nasko: PTAL.

This is the CL to support the WebRequest API in PlzNavigate. There are still a
few tests failing, including one due to - yet another - issue in the way we
track the loading state of a frame.

[Devlin, 2016-09-16 16:17:27]

A few quick comments - I'll take another look soon.

https://codereview.chromium.org/2335133003/diff/80001/chrome/browser/renderer...
File chrome/browser/renderer_host/chrome_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/80001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:25: // Any
nit: wrapping

https://codereview.chromium.org/2335133003/diff/80001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/webrequest/test_simple.js (right):

https://codereview.chromium.org/2335133003/diff/80001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/webrequest/test_simple.js:49:
console.log("Before simple load");
nit: remove debugging logs

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api.cc:1029: if
(content::IsBrowserSideNavigationEnabled() && navigation_ui_data && info &&
In which scenarios can these (null ui_data, info) happen?  Can you add a comment
explaining?  If they do happen, will the frame id map have any more information
about the request?  Also, can we not curry this information through for
subresources like images, etc?

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_event_details.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_details.cc:205:
dict_.SetInteger(keys::kTabIdKey, frame_data.tab_id);
SetFrameData?

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/exte...
File extensions/browser/extension_navigation_ui_data.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/exte...
extensions/browser/extension_navigation_ui_data.cc:17: frame_data_.frame_id =
ExtensionApiFrameIdMap::GetFrameId(navigation_handle);
It makes me a little sad that we now have two separate sources for this
information - the NavigationUIData, and the FrameIdMap.  I think ideally, we'd
only have the single spot.  That's probably a bit out of scope for this CL, but
can we add a TODO to that effect?

[clamy, 2016-09-19 15:09:44]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 15:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-09-19 15:10:04]

Thanks!

https://codereview.chromium.org/2335133003/diff/80001/chrome/browser/renderer...
File chrome/browser/renderer_host/chrome_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/80001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:25: // Any
On 2016/09/16 16:17:26, Devlin wrote:
> nit: wrapping

Done.

https://codereview.chromium.org/2335133003/diff/80001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/webrequest/test_simple.js (right):

https://codereview.chromium.org/2335133003/diff/80001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/webrequest/test_simple.js:49:
console.log("Before simple load");
On 2016/09/16 16:17:26, Devlin wrote:
> nit: remove debugging logs

Done.

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api.cc:1029: if
(content::IsBrowserSideNavigationEnabled() && navigation_ui_data && info &&
On 2016/09/16 16:17:26, Devlin wrote:
> In which scenarios can these (null ui_data, info) happen?  Can you add a
comment
> explaining?  If they do happen, will the frame id map have any more
information
> about the request?  Also, can we not curry this information through for
> subresources like images, etc?

I have added a comment that explains the check. Also, in the case of PlzNavgate
navigation, navigation_ui_data shouldn't be null, hence I switched to using a
DCHECK.

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_event_details.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_details.cc:205:
dict_.SetInteger(keys::kTabIdKey, frame_data.tab_id);
On 2016/09/16 16:17:26, Devlin wrote:
> SetFrameData?

Done.

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/exte...
File extensions/browser/extension_navigation_ui_data.cc (right):

https://codereview.chromium.org/2335133003/diff/80001/extensions/browser/exte...
extensions/browser/extension_navigation_ui_data.cc:17: frame_data_.frame_id =
ExtensionApiFrameIdMap::GetFrameId(navigation_handle);
On 2016/09/16 16:17:26, Devlin wrote:
> It makes me a little sad that we now have two separate sources for this
> information - the NavigationUIData, and the FrameIdMap.  I think ideally, we'd
> only have the single spot.  That's probably a bit out of scope for this CL,
but
> can we add a TODO to that effect?

Done.

[commit-bot: I haz the power, 2016-09-19 16:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:12:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[clamy, 2016-09-20 11:32:03]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:51:00]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-21 23:02:28]

extensions stuff lgtm.  I didn't look too closely at the content/ area; assuming
Nasko will review that.

[nasko, 2016-09-22 18:32:51]

Overall LGTM, some minor nits.

https://codereview.chromium.org/2335133003/diff/140001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.h:338:
std::unique_ptr<NavigationUIData> navigation_ui_data_;
nit: Let's put this closer to the IO thread one, SSLStatus can remain as the
last entry.

https://codereview.chromium.org/2335133003/diff/140001/content/browser/loader...
File content/browser/loader/resource_loader.cc (right):

https://codereview.chromium.org/2335133003/diff/140001/content/browser/loader...
content/browser/loader/resource_loader.cc:491: if (weak_self.get())
This seems like a generic issue unrelated to the goal of the CL, right? If so,
can we land it separately?

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
File content/public/browser/navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
content/public/browser/navigation_ui_data.h:20: // Creates a new NavigationData
that is a deep copy of the original
nit: End sentence with a period.

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
File content/public/browser/resource_request_info.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
content/public/browser/resource_request_info.h:157: // Only used for main
resources. Returns opaque data set by the embedder on
What is "main resource"? What about subframe navigations, aren't those covered?

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
File extensions/browser/extension_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
extensions/browser/extension_navigation_ui_data.h:19: class
ExtensionNavigationUIData {
Class level comment about what this is used for? Also, clarification which
thread this object is used on will be useful to have.

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
extensions/browser/extension_navigation_ui_data.h:32: void set_frame_data(const
ExtensionApiFrameIdMap::FrameData& frame_data) {
Does this need to be a public method?

[clamy, 2016-09-26 15:34:27]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 15:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-09-26 15:36:13]

clamy@chromium.org changed reviewers:
+ sky@chromium.org

[clamy, 2016-09-26 15:37:51]

@nasko,rdcronin: Thanks!
@sky: PTAL at the changes in chrome/

https://codereview.chromium.org/2335133003/diff/140001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.h:338:
std::unique_ptr<NavigationUIData> navigation_ui_data_;
On 2016/09/22 18:32:50, nasko (slow) wrote:
> nit: Let's put this closer to the IO thread one, SSLStatus can remain as the
> last entry.

Done.

https://codereview.chromium.org/2335133003/diff/140001/content/browser/loader...
File content/browser/loader/resource_loader.cc (right):

https://codereview.chromium.org/2335133003/diff/140001/content/browser/loader...
content/browser/loader/resource_loader.cc:491: if (weak_self.get())
On 2016/09/22 18:32:50, nasko (slow) wrote:
> This seems like a generic issue unrelated to the goal of the CL, right? If so,
> can we land it separately?

Done.

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
File content/public/browser/navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
content/public/browser/navigation_ui_data.h:20: // Creates a new NavigationData
that is a deep copy of the original
On 2016/09/22 18:32:50, nasko (slow) wrote:
> nit: End sentence with a period.

Done.

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
File content/public/browser/resource_request_info.h (right):

https://codereview.chromium.org/2335133003/diff/140001/content/public/browser...
content/public/browser/resource_request_info.h:157: // Only used for main
resources. Returns opaque data set by the embedder on
On 2016/09/22 18:32:50, nasko (slow) wrote:
> What is "main resource"? What about subframe navigations, aren't those
covered?

I meant the load of the main resource of each frame (including subframe).
Switched to using navigation which is less confusing.

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
File extensions/browser/extension_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
extensions/browser/extension_navigation_ui_data.h:19: class
ExtensionNavigationUIData {
On 2016/09/22 18:32:51, nasko (slow) wrote:
> Class level comment about what this is used for? Also, clarification which
> thread this object is used on will be useful to have.

Done.

https://codereview.chromium.org/2335133003/diff/140001/extensions/browser/ext...
extensions/browser/extension_navigation_ui_data.h:32: void set_frame_data(const
ExtensionApiFrameIdMap::FrameData& frame_data) {
On 2016/09/22 18:32:51, nasko (slow) wrote:
> Does this need to be a public method?

Done.

[sky, 2016-09-26 16:45:48]

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right):

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.cc:18: int tab_id =
session_tab_helper ? session_tab_helper->session_id().id() : -1;
Is there a define for the -1 you can use?

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.cc:30:
std::unique_ptr<ChromeNavigationUIData> copy(new ChromeNavigationUIData());
MakeUnique.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:18: class
ChromeNavigationUIData : public content::NavigationUIData {
Please add a description.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:32: extension_data_ =
std::move(extension_data);
Move to .cc as this make end up deleting and so isn't necessarily cheap.

[commit-bot: I haz the power, 2016-09-26 17:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:26:26]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[clamy, 2016-09-27 14:55:32]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:55:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-09-27 14:57:53]

Thanks!
@nasko: I have made a few changes in the content/ code due to
https://codereview.chromium.org/2364943002/ landing.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right):

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.cc:18: int tab_id =
session_tab_helper ? session_tab_helper->session_id().id() : -1;
On 2016/09/26 16:45:47, sky wrote:
> Is there a define for the -1 you can use?

Unfortunately, there doesn't seem to be. Eventually this is used to instantiate
an ExtensionApiFrameIdMap::FrameData, that has default values of -1 for those
values (see
https://cs.chromium.org/chromium/src/extensions/browser/extension_api_frame_i...).
The code in SessionTabHelper doesn't have constant defined either.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.cc:30:
std::unique_ptr<ChromeNavigationUIData> copy(new ChromeNavigationUIData());
On 2016/09/26 16:45:47, sky wrote:
> MakeUnique.

Done.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_navigation_ui_data.h (right):

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:18: class
ChromeNavigationUIData : public content::NavigationUIData {
On 2016/09/26 16:45:47, sky wrote:
> Please add a description.

Done.

https://codereview.chromium.org/2335133003/diff/180001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_navigation_ui_data.h:32: extension_data_ =
std::move(extension_data);
On 2016/09/26 16:45:47, sky wrote:
> Move to .cc as this make end up deleting and so isn't necessarily cheap.

Done.

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
File content/browser/frame_host/navigator_delegate.h (right):

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
content/browser/frame_host/navigator_delegate.h:150: virtual
std::unique_ptr<NavigationUIData> GetNavigationUIData(
@nasko: I have added this to avoid the NavigationHandleImpl calling
ContentBrowserClient when the handle is for an interstitial page.

[commit-bot: I haz the power, 2016-09-27 16:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 16:00:37]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-09-27 16:33:31]

LGTM

[nasko, 2016-09-28 17:28:31]

Still LGTM.

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.cc:387: if
(IsBrowserSideNavigationEnabled()) {
nit: No need for {}.

[nasko, 2016-09-28 17:28:39]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-09-28 17:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2335133003/#ps220001
(title: "Addressed comments + changes to NavigationHandleImpl following
2364943002")

[commit-bot: I haz the power, 2016-09-28 17:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:33:03]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[clamy, 2016-09-29 15:56:21]

Thanks!

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2335133003/diff/220001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.cc:387: if
(IsBrowserSideNavigationEnabled()) {
On 2016/09/28 17:28:31, nasko (slow) wrote:
> nit: No need for {}.

Done.

[clamy, 2016-09-29 15:56:38]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-09-29 15:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, sky@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2335133003/#ps240001
(title: "Rebase + addressed nit")

[commit-bot: I haz the power, 2016-09-29 15:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 16:49:09]

Description was changed from

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-09-29 16:49:11]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-09-29 16:52:44]

Description was changed from

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: support the WebRequest API

This CL introduces support for the WebRequest API when browser-side
navigation is enabled. It introduces a struct NavigationUIData that the
extension code can initialize on the UI thread at the beginning of the
navigation. Later the WebRequest code accesses it on the IO thread and
uses it to get a properly initialized FrameData.

BUG=575224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1e5574e9aa99ff49474912f87c1bf2b3924bd24d
Cr-Commit-Position: refs/heads/master@{#421846}
==========

[commit-bot: I haz the power, 2016-09-29 16:52:46]

Patchset 13 (id:??) landed as
https://crrev.com/1e5574e9aa99ff49474912f87c1bf2b3924bd24d
Cr-Commit-Position: refs/heads/master@{#421846}