Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2335093002: Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (Closed)

Created:
4 years, 3 months ago by tikuta
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (patchset #1 id:1 of https://codereview.chromium.org/2328263002/ ) Reason for revert: https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/2972/steps/generate%20build%20files%20for%20chromeos/logs/stdio args for gn uses old goma_dir. Original issue's description: > Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py > > * use chromium.ensure_goma() > > BUG=621828 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/bcdf12617db069e17f963d54e50d1afe44508911 TBR=iannucci@chromium.org,shinyak@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621828 Committed: https://chromium.googlesource.com/chromium/tools/build/+/6d3aa7f7ec03f77f8f1e9ecfd5e4a7c613a31943

Patch Set 1 #

Messages

Total messages: 19 (9 generated)
tikuta
Created Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py
4 years, 3 months ago (2016-09-13 03:55:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335093002/1
4 years, 3 months ago (2016-09-13 03:56:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 03:56:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335093002/1
4 years, 3 months ago (2016-09-13 04:04:54 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 04:04:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335093002/1
4 years, 3 months ago (2016-09-13 04:05:35 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 04:05:41 UTC) #14
shinyak
lgtm
4 years, 3 months ago (2016-09-13 04:06:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335093002/1
4 years, 3 months ago (2016-09-13 04:06:25 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 04:06:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6d3aa7f7ec03f77f8f1e...

Powered by Google App Engine
This is Rietveld 408576698