Issue 2335083002: [turbofan] Avoid shadowing of local variables.

Issue 2335083002: [turbofan] Avoid shadowing of local variables. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer

Modified:
4 years, 3 months ago

Reviewers:
Jarin, brucedawson

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Avoid shadowing of local variables. Cleanup fix addressing the comment on crrev.com/2325943002. TBR=jarin@chromium.org,brucedawson@chromium.org Committed: https://crrev.com/fe952ee1693c66ab1a9be339e61c4b97931a38c2 Cr-Commit-Position: refs/heads/master@{#39364}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	src/compiler/js-inlining-heuristic.cc	View		3 chunks	+13 lines, -11 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335083002/1

4 years, 3 months ago (2016-09-13 03:44:55 UTC) #6

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/fe952ee1693c66ab1a9be339e61c4b97931a38c2 Cr-Commit-Position: refs/heads/master@{#39364}

4 years, 3 months ago (2016-09-13 04:11:28 UTC) #9

brucedawson

4 years, 3 months ago (2016-09-13 17:10:51 UTC) #10

Message was sent while issue was closed.

Thanks for the fix. I like that way of resolving it because it makes it clear
that there are no stale references to 'control' left hidden. lgtm