Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2335073003: Move DOMError to modules/quota (Closed)

Created:
4 years, 3 months ago by rwlbuis
Modified:
4 years, 3 months ago
Reviewers:
haraken, jsbell
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-css, sof, eae+blinkwatch, nhiroki, blink-reviews-events_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, kinuko+watch, tzik, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DOMError to modules/quota DOMError is only used in quota, so may as well move it there while waiting for the deprecated parts of quota to be removed. This patch also removes unneeded DOMError includes. BUG=460725 Committed: https://crrev.com/37968badbaf894849a000b2d0000eeb506fde0da Cr-Commit-Position: refs/heads/master@{#418477}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -175 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMError.h View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMError.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMError.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/quota/DOMError.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/quota/DOMError.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/quota/DOMError.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuota.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaCallbacksImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
rwlbuis
PTAL. I guess removing deprecated quota parts is still some way off, so this may ...
4 years, 3 months ago (2016-09-13 19:51:14 UTC) #5
jsbell
lgtm
4 years, 3 months ago (2016-09-13 22:11:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335073003/40001
4 years, 3 months ago (2016-09-13 23:08:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/258790)
4 years, 3 months ago (2016-09-13 23:17:16 UTC) #10
haraken
owner LGTM
4 years, 3 months ago (2016-09-13 23:58:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335073003/40001
4 years, 3 months ago (2016-09-14 01:10:14 UTC) #13
rwlbuis
On 2016/09/13 23:58:44, haraken wrote: > owner LGTM Thanks, I forgot I needed multiple reviewers.
4 years, 3 months ago (2016-09-14 02:14:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-14 03:40:47 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:44:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37968badbaf894849a000b2d0000eeb506fde0da
Cr-Commit-Position: refs/heads/master@{#418477}

Powered by Google App Engine
This is Rietveld 408576698