Prepare DedicatedWorker for per thread heap

third_party/WebKit/Source/core/workers/WorkerBackingThread.h

Index: third_party/WebKit/Source/core/workers/WorkerBackingThread.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerBackingThread.h b/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
index c47a3ac402232c12f458a52bc08f9f741512da9e..f4d94c8b5eef4a418a362384042df377583ec5e9 100644
--- a/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
+++ b/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
@@ -27,12 +27,12 @@ class WebThreadSupportingGC;
 // WorkerGlobalScopes) can share one WorkerBackingThread.
 class CORE_EXPORT WorkerBackingThread final {
 public:
-    static std::unique_ptr<WorkerBackingThread> create(const char* name) { return wrapUnique(new WorkerBackingThread(name, false)); }
+    static std::unique_ptr<WorkerBackingThread> create(const char* name, bool enablePerThreadHeap = false) { return wrapUnique(new WorkerBackingThread(name, false, enablePerThreadHeap)); }

[nhiroki, 2016/09/14 07:59:46]

I'd prefer that each thread explicitly specifies whether to enable the
per-thread heap for readability. I guess there are only a few callsites of this
and it couldn't be so difficult to add them.

[keishi, 2016/09/21 04:57:25]

Done in https://codereview.chromium.org/2355193002/ .

     static std::unique_ptr<WorkerBackingThread> create(WebThread* thread) { return wrapUnique(new WorkerBackingThread(thread, false)); }
 
     // These are needed to suppress leak reports. See
     // https://crbug.com/590802 and https://crbug.com/v8/1428.
-    static std::unique_ptr<WorkerBackingThread> createForTest(const char* name) { return wrapUnique(new WorkerBackingThread(name, true)); }
+    static std::unique_ptr<WorkerBackingThread> createForTest(const char* name, bool enablePerThreadHeap = false) { return wrapUnique(new WorkerBackingThread(name, true, enablePerThreadHeap)); }

[nhiroki, 2016/09/14 07:59:46]

This is used by WorkerThreadTest that is a set of tests for common worker
infrastructure. We might want to modify the tests to run on both per-thread heap
and non-per-thread heap environments.

[keishi, 2016/09/21 04:57:25]

Done. Added INSTANTIATE_TEST_CASE_P for both cases.

     static std::unique_ptr<WorkerBackingThread> createForTest(WebThread* thread) { return wrapUnique(new WorkerBackingThread(thread, true)); }
 
     ~WorkerBackingThread();
@@ -58,7 +58,7 @@ public:
     static void setRAILModeOnWorkerThreadIsolates(v8::RAILMode);
 
 private:
-    WorkerBackingThread(const char* name, bool shouldCallGCOnShutdown);
+    WorkerBackingThread(const char* name, bool shouldCallGCOnShutdown, bool enablePerThreadHeap);
     WorkerBackingThread(WebThread*, bool shouldCallGCOnSHutdown);
 
     std::unique_ptr<WebThreadSupportingGC> m_backingThread;