Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: components/previews/core/previews_io_data_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/previews/core/previews_io_data.cc ('k') | components/previews/core/previews_opt_out_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/previews/core/previews_io_data_unittest.cc
diff --git a/components/previews/core/previews_io_data_unittest.cc b/components/previews/core/previews_io_data_unittest.cc
index c2907d9ec691e33f42fdbd677d3c765bf337b024..1475e9590f8bca4d257a030242336447dd23fa1f 100644
--- a/components/previews/core/previews_io_data_unittest.cc
+++ b/components/previews/core/previews_io_data_unittest.cc
@@ -2,21 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/previews/core/previews_io_data.h"
#include <memory>
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "components/previews/core/previews_ui_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace previews {
namespace {
class TestPreviewsIOData : public PreviewsIOData {
public:
@@ -24,23 +23,24 @@ class TestPreviewsIOData : public PreviewsIOData {
const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner)
: PreviewsIOData(io_task_runner, ui_task_runner), initialized_(false) {}
~TestPreviewsIOData() override {}
// Whether Initialize was called.
bool initialized() { return initialized_; }
private:
// Set |initialized_| to true and use base class functionality.
- void InitializeOnIOThread() override {
+ void InitializeOnIOThread(
+ std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store) override {
initialized_ = true;
- PreviewsIOData::InitializeOnIOThread();
+ PreviewsIOData::InitializeOnIOThread(std::move(previews_opt_out_store));
}
// Whether Initialize was called.
bool initialized_;
};
class PreviewsIODataTest : public testing::Test {
public:
PreviewsIODataTest() {}
@@ -63,19 +63,19 @@ class PreviewsIODataTest : public testing::Test {
private:
std::unique_ptr<TestPreviewsIOData> io_data_;
std::unique_ptr<PreviewsUIService> ui_service_;
};
} // namespace
TEST_F(PreviewsIODataTest, TestInitialization) {
set_io_data(base::WrapUnique(
new TestPreviewsIOData(loop_.task_runner(), loop_.task_runner())));
- set_ui_service(
- base::WrapUnique(new PreviewsUIService(io_data(), loop_.task_runner())));
- base::RunLoop().RunUntilIdle();
+ set_ui_service(base::WrapUnique(
+ new PreviewsUIService(io_data(), loop_.task_runner(), nullptr)));
+ loop_.RunUntilIdle();
// After the outstanding posted tasks have run, |io_data_| should be fully
// initialized.
EXPECT_TRUE(io_data()->initialized());
}
} // namespace previews
« no previous file with comments | « components/previews/core/previews_io_data.cc ('k') | components/previews/core/previews_opt_out_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698