Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: components/previews/core/previews_black_list.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/previews/core/previews_black_list.h ('k') | components/previews/core/previews_black_list_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/previews/core/previews_black_list.cc
diff --git a/components/previews/core/previews_black_list.cc b/components/previews/core/previews_black_list.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f4b277b6f231ee0f0e6b4dca36c274bd30b29f94
--- /dev/null
+++ b/components/previews/core/previews_black_list.cc
@@ -0,0 +1,150 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/previews/core/previews_black_list.h"
+
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "base/optional.h"
+#include "base/time/clock.h"
+#include "base/time/time.h"
+#include "components/previews/core/previews_black_list_item.h"
+#include "components/previews/core/previews_experiments.h"
+#include "url/gurl.h"
+
+namespace previews {
+
+PreviewsBlackList::PreviewsBlackList(
+ std::unique_ptr<PreviewsOptOutStore> opt_out_store,
+ std::unique_ptr<base::Clock> clock)
+ : loaded_(false),
+ opt_out_store_(std::move(opt_out_store)),
+ clock_(std::move(clock)),
+ weak_factory_(this) {
+ if (opt_out_store_) {
+ opt_out_store_->LoadBlackList(base::Bind(
+ &PreviewsBlackList::LoadBlackListDone, weak_factory_.GetWeakPtr()));
+ } else {
+ LoadBlackListDone(base::MakeUnique<BlackListItemMap>());
+ }
+}
+
+PreviewsBlackList::~PreviewsBlackList() {}
+
+void PreviewsBlackList::AddPreviewNavigation(const GURL& url,
+ bool opt_out,
+ PreviewsType type) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(url.has_host());
+ // If the |black_list_item_map_| has been loaded from |opt_out_store_|,
+ // synchronous operations will be accurate. Otherwise, queue the task to run
+ // asynchronously.
+ if (loaded_) {
+ AddPreviewNavigationSync(url, opt_out, type);
+ } else {
+ QueuePendingTask(base::Bind(&PreviewsBlackList::AddPreviewNavigationSync,
+ base::Unretained(this), url, opt_out, type));
+ }
+}
+
+void PreviewsBlackList::AddPreviewNavigationSync(const GURL& url,
+ bool opt_out,
+ PreviewsType type) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(url.has_host());
+ DCHECK(loaded_);
+ std::string host_name = url.host();
+ base::Time now = clock_->Now();
+ PreviewsBlackListItem* item = GetBlackListItem(host_name);
+ if (!item) {
+ item = CreateBlackListItem(host_name);
+ }
+ item->AddPreviewNavigation(opt_out, now);
+ DCHECK_LE(black_list_item_map_->size(),
+ params::MaxInMemoryHostsInBlackList());
+ if (!opt_out_store_)
+ return;
+ opt_out_store_->AddPreviewNavigation(opt_out, host_name, type, now);
+}
+
+bool PreviewsBlackList::IsLoadedAndAllowed(const GURL& url,
+ PreviewsType type) const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(url.has_host());
+ if (!loaded_)
+ return false;
+ PreviewsBlackListItem* black_list_item = GetBlackListItem(url.host());
+ return !black_list_item || !black_list_item->IsBlackListed(clock_->Now());
+}
+
+void PreviewsBlackList::QueuePendingTask(base::Closure callback) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(!loaded_);
+ DCHECK(!callback.is_null());
+ pending_callbacks_.emplace(callback);
+}
+
+void PreviewsBlackList::LoadBlackListDone(
+ std::unique_ptr<BlackListItemMap> black_list_item_map) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK_LE(black_list_item_map->size(), params::MaxInMemoryHostsInBlackList());
+ loaded_ = true;
+ black_list_item_map_ = std::move(black_list_item_map);
+
+ // Run all pending tasks. |loaded_| may change if ClearBlackList is queued.
+ while (pending_callbacks_.size() > 0 && loaded_) {
+ pending_callbacks_.front().Run();
+ pending_callbacks_.pop();
+ }
+}
+
+PreviewsBlackListItem* PreviewsBlackList::GetBlackListItem(
+ const std::string& host_name) const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(loaded_);
+ BlackListItemMap::iterator iter = black_list_item_map_->find(host_name);
+ if (iter != black_list_item_map_->end())
+ return iter->second.get();
+ return nullptr;
+}
+
+PreviewsBlackListItem* PreviewsBlackList::CreateBlackListItem(
+ const std::string& host_name) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(loaded_);
+ DCHECK(!GetBlackListItem(host_name));
+ if (black_list_item_map_->size() >= params::MaxInMemoryHostsInBlackList())
+ EvictOldestOptOut();
+ DCHECK_LT(black_list_item_map_->size(),
+ params::MaxInMemoryHostsInBlackList());
+ PreviewsBlackListItem* black_list_item = new PreviewsBlackListItem(
+ params::MaxStoredHistoryLengthForBlackList(),
+ params::BlackListOptOutThreshold(), params::BlackListDuration());
+ black_list_item_map_->operator[](host_name) =
+ base::WrapUnique(black_list_item);
+ return black_list_item;
+}
+
+void PreviewsBlackList::EvictOldestOptOut() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(loaded_);
+ // TODO(ryansturm): Add UMA. crbug.com/647717
+ BlackListItemMap::iterator item_to_delete = black_list_item_map_->end();
+ base::Time oldest_opt_out = clock_->Now();
+ for (BlackListItemMap::iterator iter = black_list_item_map_->begin();
+ iter != black_list_item_map_->end(); ++iter) {
+ if (!iter->second->most_recent_opt_out_time()) {
+ // If there is no opt out time, this is a good choice to evict.
+ item_to_delete = iter;
+ break;
+ }
+ if (iter->second->most_recent_opt_out_time().value() < oldest_opt_out) {
+ oldest_opt_out = iter->second->most_recent_opt_out_time().value();
+ item_to_delete = iter;
+ }
+ }
+ black_list_item_map_->erase(item_to_delete);
+}
+
+} // namespace previews
« no previous file with comments | « components/previews/core/previews_black_list.h ('k') | components/previews/core/previews_black_list_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698