Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: components/previews/previews_experiments_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/previews_experiments_unittest.cc
diff --git a/components/previews/previews_experiments_unittest.cc b/components/previews/previews_experiments_unittest.cc
index c66e2e0ab97d4d1f0cd3051f81ded9780dd519fd..005ea448742c09033aae3d8dbe340c8fafc9667b 100644
--- a/components/previews/previews_experiments_unittest.cc
+++ b/components/previews/previews_experiments_unittest.cc
@@ -1,29 +1,39 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/previews/previews_experiments.h"
+#include <string>
+
#include "base/metrics/field_trial.h"
+#include "base/strings/string_number_conversions.h"
+#include "components/variations/variations_associated_data.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using PreviewsExperimentsTest = testing::Test;
} // namespace
namespace previews {
TEST_F(PreviewsExperimentsTest, TestFieldTrialOfflinePage) {
EXPECT_FALSE(IsIncludedInClientSidePreviewsExperimentsFieldTrial());
EXPECT_FALSE(IsOfflinePreviewsEnabled());
base::FieldTrialList field_trial_list(nullptr);
- ASSERT_TRUE(EnableOfflinePreviewsForTesting());
+ std::map<std::string, std::string> params;
tbansal1 2016/09/14 21:36:26 #include map
RyanSturm 2016/09/14 22:41:26 I decided to remove EnableOfflinePreviewsForTestin
+ params["show_offline_pages"] = "true";
+ ASSERT_TRUE(
+ variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
+ params) &&
+ base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
EXPECT_TRUE(IsIncludedInClientSidePreviewsExperimentsFieldTrial());
EXPECT_TRUE(IsOfflinePreviewsEnabled());
+ variations::testing::ClearAllVariationParams();
}
} // namespace previews

Powered by Google App Engine
This is Rietveld 408576698