Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/previews/previews_black_list_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/previews_black_list_unittest.cc
diff --git a/components/previews/previews_black_list_unittest.cc b/components/previews/previews_black_list_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4b7926f9c8ecad8cf08642e195a702901c950400
--- /dev/null
+++ b/components/previews/previews_black_list_unittest.cc
@@ -0,0 +1,164 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/previews/previews_black_list.h"
+
+#include <memory>
+#include <string>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/metrics/field_trial.h"
+#include "base/run_loop.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/time/time.h"
+#include "components/previews/previews_black_list_item.h"
+#include "components/previews/previews_experiments.h"
+#include "components/previews/previews_opt_out_store.h"
+#include "components/variations/variations_associated_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace {
+
+using PreviewsBlackListTest = testing::Test;
+
+} // namespace
+
+namespace previews {
+
+namespace {
+
+void RunLoadCallback(LoadBlackListCallback callback,
+ std::unique_ptr<BlackListItemMap> black_list_item_map) {
+ callback.Run(std::move(black_list_item_map));
+}
+
+class TestPreviewsOptOutStore : public PreviewsOptOutStore {
+ public:
+ TestPreviewsOptOutStore() {}
+ ~TestPreviewsOptOutStore() override {}
+
+ private:
+ // PreviewsOptOutStore implementation:
+ void AddPreviewNavigation(bool opt_out,
+ const std::string& host_name,
+ PreviewsType type,
+ const base::Time& now) override {}
+ void LoadBlackList(LoadBlackListCallback callback) override {
+ std::unique_ptr<BlackListItemMap> black_list_item_map(
+ new BlackListItemMap());
+ base::MessageLoop::current()->task_runner()->PostTask(
+ FROM_HERE, base::Bind(&RunLoadCallback, callback,
+ base::Passed(&black_list_item_map)));
+ }
+};
+
+} // namespace
+
+TEST_F(PreviewsBlackListTest, BlackListNoStore) {
+ const GURL url_a("http://www.url_a.com");
+ const GURL url_b("http://www.url_b.com");
+ const size_t history = 4;
+ const int threshold = 2;
+ // Hopefully, this test runs within a calendar year.
+ const int duration_in_seconds = 1 * 365 * 24 * 60 * 60;
+ base::FieldTrialList field_trial_list(nullptr);
+ std::map<std::string, std::string> params;
+ params["stored_history_length"] = base::SizeTToString(history);
+ params["opt_out_threshold"] = base::IntToString(threshold);
+ params["black_list_duration"] = base::IntToString(duration_in_seconds);
+ ASSERT_TRUE(
+ variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
+ params) &&
+ base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
+
+ std::unique_ptr<PreviewsBlackList> black_list(new PreviewsBlackList(nullptr));
+
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_a, true, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_a, true, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ variations::testing::ClearAllVariationParams();
+}
+
+TEST_F(PreviewsBlackListTest, BlackListWithStore) {
+ const GURL url_a1("http://www.url_a.com/a1");
+ const GURL url_a2("http://www.url_a.com/a2");
+ const GURL url_b("http://www.url_b.com");
+ const size_t history = 4;
+ const int threshold = 2;
+ // Hopefully, this test runs within a calendar year.
+ const int duration_in_seconds = 1 * 365 * 24 * 60 * 60;
+ base::FieldTrialList field_trial_list(nullptr);
+ std::map<std::string, std::string> params;
+ params["stored_history_length"] = base::SizeTToString(history);
+ params["opt_out_threshold"] = base::IntToString(threshold);
+ params["black_list_duration"] = base::IntToString(duration_in_seconds);
+ ASSERT_TRUE(
+ variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
+ params) &&
+ base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
+
+ base::MessageLoop loop;
+
+ std::unique_ptr<PreviewsBlackList> black_list(
+ new PreviewsBlackList(base::MakeUnique<TestPreviewsOptOutStore>()));
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_a1, true, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_a1, true, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+ black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
+
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
+ EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
+ EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
+
+ variations::testing::ClearAllVariationParams();
+}
+
+} // namespace previews

Powered by Google App Engine
This is Rietveld 408576698