Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: components/previews/previews_ui_service_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/previews_ui_service_unittest.cc
diff --git a/components/previews/previews_ui_service_unittest.cc b/components/previews/previews_ui_service_unittest.cc
index 6080ce27c1fef9da5ba1032a641f02730484b03c..a374b870b47c9b3b79ef88ef8a1be9a2794364e3 100644
--- a/components/previews/previews_ui_service_unittest.cc
+++ b/components/previews/previews_ui_service_unittest.cc
@@ -14,22 +14,25 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace previews {
namespace {
class TestPreviewsUIService : public PreviewsUIService {
public:
TestPreviewsUIService(
PreviewsIOData* previews_io_data,
- const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner)
- : PreviewsUIService(previews_io_data, io_task_runner),
+ const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
+ std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store)
+ : PreviewsUIService(previews_io_data,
+ io_task_runner,
+ std::move(previews_opt_out_store)),
io_data_set_(false) {}
~TestPreviewsUIService() override {}
// Set |io_data_set_| to true and use base class functionality.
void SetIOData(base::WeakPtr<PreviewsIOData> previews_io_data) override {
io_data_set_ = true;
PreviewsUIService::SetIOData(previews_io_data);
}
// Whether SetIOData was called.
@@ -66,18 +69,18 @@ class PreviewsUIServiceTest : public testing::Test {
std::unique_ptr<PreviewsIOData> io_data_;
std::unique_ptr<TestPreviewsUIService> ui_service_;
};
} // namespace
TEST_F(PreviewsUIServiceTest, TestInitialization) {
set_io_data(base::WrapUnique(
new PreviewsIOData(loop_.task_runner(), loop_.task_runner())));
set_ui_service(base::WrapUnique(
- new TestPreviewsUIService(io_data(), loop_.task_runner())));
+ new TestPreviewsUIService(io_data(), loop_.task_runner(), nullptr)));
loop_.RunUntilIdle();
// After the outstanding posted tasks have run, SetIOData should have been
// called for |ui_service_|.
EXPECT_TRUE(ui_service()->io_data_set());
}
} // namespace previews
« components/previews/previews_ui_service.cc ('K') | « components/previews/previews_ui_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698