Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: components/previews/previews_io_data.h

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/previews_io_data.h
diff --git a/components/previews/previews_io_data.h b/components/previews/previews_io_data.h
index 4017d79202984d2cbe1b5c696352a68f3add3968..c47660336ae9bf9de266c17ad5e69004d9ea46a9 100644
--- a/components/previews/previews_io_data.h
+++ b/components/previews/previews_io_data.h
@@ -1,51 +1,61 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef COMPONENTS_PREVIEWS_PREVIEWS_IO_DATA_H_
#define COMPONENTS_PREVIEWS_PREVIEWS_IO_DATA_H_
+#include <memory>
#include <string>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
-#include "base/threading/thread_checker.h"
+#include "base/time/time.h"
+#include "components/previews/previews_opt_out_store.h"
namespace previews {
+class PreviewsBlackList;
class PreviewsUIService;
+enum class PreviewsType;
// A class to manage the IO portion of inter-thread communication between
// previews/ objects. Created on the UI thread, but used only on the IO thread
// after initialization.
class PreviewsIOData {
public:
PreviewsIOData(
const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner);
virtual ~PreviewsIOData();
// Stores |previews_ui_service| as |previews_ui_service_| and posts a task to
// InitializeOnIOThread on the IO thread.
- void Initialize(base::WeakPtr<PreviewsUIService> previews_ui_service);
+ void Initialize(base::WeakPtr<PreviewsUIService> previews_ui_service,
+ std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store);
+
+ PreviewsBlackList* black_list() { return black_list_.get(); }
protected:
// Posts a task to SetIOData for |previews_ui_service_| on the UI thread with
// a weak pointer to |this|. Virtualized for testing.
- virtual void InitializeOnIOThread();
+ virtual void InitializeOnIOThread(
+ std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store);
private:
// The UI thread portion of the inter-thread communication for previews.
base::WeakPtr<PreviewsUIService> previews_ui_service_;
+ std::unique_ptr<PreviewsBlackList> black_list_;
+
// The UI and IO thread task runners. |ui_task_runner_| is used to post
// tasks to |previews_ui_service_|, and |io_task_runner_| is used to post from
// Initialize to InitializeOnIOThread as well as verify that execution is
// happening on the IO thread.
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
base::WeakPtrFactory<PreviewsIOData> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(PreviewsIOData);

Powered by Google App Engine
This is Rietveld 408576698