Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: components/previews/previews_black_list_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/previews/previews_black_list.h"
6
7 #include <memory>
8 #include <string>
9
10 #include "base/bind.h"
11 #include "base/bind_helpers.h"
12 #include "base/memory/ptr_util.h"
13 #include "base/message_loop/message_loop.h"
14 #include "base/metrics/field_trial.h"
15 #include "base/run_loop.h"
16 #include "base/strings/string_number_conversions.h"
17 #include "base/time/time.h"
18 #include "components/previews/previews_black_list_item.h"
19 #include "components/previews/previews_experiments.h"
20 #include "components/previews/previews_opt_out_store.h"
21 #include "components/variations/variations_associated_data.h"
22 #include "testing/gtest/include/gtest/gtest.h"
23 #include "url/gurl.h"
24
25 namespace {
26
27 using PreviewsBlackListTest = testing::Test;
28
29 } // namespace
30
31 namespace previews {
32
33 namespace {
34
35 void RunLoadCallback(LoadBlackListCallback callback,
36 std::unique_ptr<BlackListItemMap> black_list_item_map) {
37 callback.Run(std::move(black_list_item_map));
38 }
39
40 class TestPreviewsOptOutStore : public PreviewsOptOutStore {
41 public:
42 TestPreviewsOptOutStore() {}
43 ~TestPreviewsOptOutStore() override {}
44
45 private:
46 // PreviewsOptOutStore implementation:
47 void AddPreviewNavigation(bool opt_out,
48 const std::string& host_name,
49 PreviewsType type,
50 base::Time now) override {}
51 void LoadBlackList(LoadBlackListCallback callback) override {
52 std::unique_ptr<BlackListItemMap> black_list_item_map(
53 new BlackListItemMap());
54 base::MessageLoop::current()->task_runner()->PostTask(
55 FROM_HERE, base::Bind(&RunLoadCallback, callback,
56 base::Passed(&black_list_item_map)));
57 }
58 };
59
60 } // namespace
61
62 TEST_F(PreviewsBlackListTest, BlackListNoStore) {
63 const GURL url_a("http://www.url_a.com");
64 const GURL url_b("http://www.url_b.com");
65 const size_t history = 4;
66 const int threshold = 2;
67 // Hopefully, this test runs within a calendar year.
68 const int duration_in_seconds = 1 * 365 * 24 * 60 * 60;
69 base::FieldTrialList field_trial_list(nullptr);
70 std::map<std::string, std::string> params;
71 params["stored_history_length"] = base::SizeTToString(history);
72 params["opt_out_threshold"] = base::IntToString(threshold);
73 params["black_list_duration"] = base::IntToString(duration_in_seconds);
74 ASSERT_TRUE(
75 variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
76 params) &&
77 base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
78
79 std::unique_ptr<PreviewsBlackList> black_list(new PreviewsBlackList(nullptr));
80
81 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
82 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
83
84 black_list->AddPreviewNavigation(url_a, true, PreviewsType::OFFLINE);
85 black_list->AddPreviewNavigation(url_a, true, PreviewsType::OFFLINE);
86
87 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
88 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
89
90 black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
91 black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
92
93 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
94 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
95
96 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
97 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
98 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
99
100 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a, PreviewsType::OFFLINE));
101 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
102
103 variations::testing::ClearAllVariationParams();
104 }
105
106 TEST_F(PreviewsBlackListTest, BlackListWithStore) {
107 const GURL url_a1("http://www.url_a.com/a1");
108 const GURL url_a2("http://www.url_a.com/a2");
109 const GURL url_b("http://www.url_b.com");
110 const size_t history = 4;
111 const int threshold = 2;
112 // Hopefully, this test runs within a calendar year.
113 const int duration_in_seconds = 1 * 365 * 24 * 60 * 60;
114 base::FieldTrialList field_trial_list(nullptr);
115 std::map<std::string, std::string> params;
116 params["stored_history_length"] = base::SizeTToString(history);
117 params["opt_out_threshold"] = base::IntToString(threshold);
118 params["black_list_duration"] = base::IntToString(duration_in_seconds);
119 ASSERT_TRUE(
120 variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
121 params) &&
122 base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
123
124 base::MessageLoop loop;
125
126 std::unique_ptr<PreviewsBlackList> black_list(
127 new PreviewsBlackList(base::MakeUnique<TestPreviewsOptOutStore>()));
128
129 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
130 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
131 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
132
133 base::RunLoop().RunUntilIdle();
134
135 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
136 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
137 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
138
139 black_list->AddPreviewNavigation(url_a1, true, PreviewsType::OFFLINE);
140 black_list->AddPreviewNavigation(url_a1, true, PreviewsType::OFFLINE);
141
142 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
143 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
144 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
145
146 black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
147 black_list->AddPreviewNavigation(url_b, true, PreviewsType::OFFLINE);
148
149 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
150 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
151 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
152
153 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
154 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
155 black_list->AddPreviewNavigation(url_b, false, PreviewsType::OFFLINE);
156
157 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a1, PreviewsType::OFFLINE));
158 EXPECT_FALSE(black_list->IsLoadedAndAllowed(url_a2, PreviewsType::OFFLINE));
159 EXPECT_TRUE(black_list->IsLoadedAndAllowed(url_b, PreviewsType::OFFLINE));
160
161 variations::testing::ClearAllVariationParams();
162 }
163
164 } // namespace previews
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698