Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Side by Side Diff: components/previews/previews_experiments_unittest.cc

Issue 2335023002: Adding a previews IO-thread blacklist (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/previews/previews_experiments.h" 5 #include "components/previews/previews_experiments.h"
6 6
7 #include <string>
8
7 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/strings/string_number_conversions.h"
11 #include "components/variations/variations_associated_data.h"
8 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
9 13
10 namespace { 14 namespace {
11 15
12 using PreviewsExperimentsTest = testing::Test; 16 using PreviewsExperimentsTest = testing::Test;
13 17
14 } // namespace 18 } // namespace
15 19
16 namespace previews { 20 namespace previews {
17 21
18 TEST_F(PreviewsExperimentsTest, TestFieldTrialOfflinePage) { 22 TEST_F(PreviewsExperimentsTest, TestFieldTrialOfflinePage) {
19 EXPECT_FALSE(IsIncludedInClientSidePreviewsExperimentsFieldTrial()); 23 EXPECT_FALSE(IsIncludedInClientSidePreviewsExperimentsFieldTrial());
20 EXPECT_FALSE(IsOfflinePreviewsEnabled()); 24 EXPECT_FALSE(IsOfflinePreviewsEnabled());
21 25
22 base::FieldTrialList field_trial_list(nullptr); 26 base::FieldTrialList field_trial_list(nullptr);
23 ASSERT_TRUE(EnableOfflinePreviewsForTesting()); 27 std::map<std::string, std::string> params;
tbansal1 2016/09/14 21:36:26 #include map
RyanSturm 2016/09/14 22:41:26 I decided to remove EnableOfflinePreviewsForTestin
28 params["show_offline_pages"] = "true";
29 ASSERT_TRUE(
30 variations::AssociateVariationParams("ClientSidePreviews", "Enabled",
31 params) &&
32 base::FieldTrialList::CreateFieldTrial("ClientSidePreviews", "Enabled"));
24 33
25 EXPECT_TRUE(IsIncludedInClientSidePreviewsExperimentsFieldTrial()); 34 EXPECT_TRUE(IsIncludedInClientSidePreviewsExperimentsFieldTrial());
26 EXPECT_TRUE(IsOfflinePreviewsEnabled()); 35 EXPECT_TRUE(IsOfflinePreviewsEnabled());
36 variations::testing::ClearAllVariationParams();
27 } 37 }
28 38
29 } // namespace previews 39 } // namespace previews
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698