Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2334963002: Add NaCl SDK bots to mbconfig.pyl (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, bradnelson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NaCl SDK bots to mbconfig.pyl BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=646185 Committed: https://crrev.com/6c94526a587330cfd69db0387c93bd49c7000f25 Cr-Commit-Position: refs/heads/master@{#418162}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Sam Clegg
4 years, 3 months ago (2016-09-12 23:30:40 UTC) #4
bradnelson
lgtm, but dpranke probably should sign off.
4 years, 3 months ago (2016-09-12 23:36:40 UTC) #5
Dirk Pranke
lgtm.
4 years, 3 months ago (2016-09-12 23:43:39 UTC) #8
Dirk Pranke
On 2016/09/12 23:43:39, Dirk Pranke wrote: > lgtm. and welcome back :)
4 years, 3 months ago (2016-09-12 23:43:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334963002/40001
4 years, 3 months ago (2016-09-13 03:39:45 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 03:43:41 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 03:46:57 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c94526a587330cfd69db0387c93bd49c7000f25
Cr-Commit-Position: refs/heads/master@{#418162}

Powered by Google App Engine
This is Rietveld 408576698