media: Update logging to indicate that new key has been provided

media: Update logging to indicate that new key has been provided

When playing encrypted media and decrypting stalls due to missing key,
add a message to indicate when a key is added and decryption tries to
start again.

BUG=645304
TEST=checked chrome://media-internals

Committed: https://crrev.com/e30a8fab234b1c9fa644f2053bd080620315536d
Cr-Commit-Position: refs/heads/master@{#419365}

[jrummell, 2016-09-12 23:16:55]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-09-12 23:16:56]

PTAL. As requested in previous CL.

[xhwang, 2016-09-12 23:20:47]

LGTM with nits

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
File media/filters/decrypting_demuxer_stream.cc (right):

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:309: << ": key was added, resuming
decode";
nit: DDS doesn't do decoding, how about "resuming decrypt"?

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:341: << ": key added, resuming
decode";
ditto

[jrummell, 2016-09-17 01:22:28]

Thanks for the review.

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
File media/filters/decrypting_demuxer_stream.cc (right):

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:309: << ": key was added, resuming
decode";
On 2016/09/12 23:20:47, xhwang (slow) wrote:
> nit: DDS doesn't do decoding, how about "resuming decrypt"?

Done.

https://codereview.chromium.org/2334953002/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:341: << ": key added, resuming
decode";
On 2016/09/12 23:20:47, xhwang (slow) wrote:
> ditto

Done.

[jrummell, 2016-09-17 01:22:33]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-09-17 01:22:34]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2334953002/#ps20001
(title: "change DDS log")

[commit-bot: I haz the power, 2016-09-17 01:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 02:43:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-17 02:45:28]

Description was changed from

==========
media: Update logging to indicate that new key has been provided

When playing encrypted media and decrypting stalls due to missing key,
add a message to indicate when a key is added and decryption tries to
start again.

BUG=645304
TEST=checked chrome://media-internals
==========

to

==========
media: Update logging to indicate that new key has been provided

When playing encrypted media and decrypting stalls due to missing key,
add a message to indicate when a key is added and decryption tries to
start again.

BUG=645304
TEST=checked chrome://media-internals

Committed: https://crrev.com/e30a8fab234b1c9fa644f2053bd080620315536d
Cr-Commit-Position: refs/heads/master@{#419365}
==========

[commit-bot: I haz the power, 2016-09-17 02:45:29]

Patchset 2 (id:??) landed as
https://crrev.com/e30a8fab234b1c9fa644f2053bd080620315536d
Cr-Commit-Position: refs/heads/master@{#419365}