Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.h

Issue 2334943002: Add a new QuicChromiumClientSession::Handle class (Closed)
Patch Set: fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/bidirectional_stream_quic_impl.h
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.h b/net/quic/chromium/bidirectional_stream_quic_impl.h
index 125658194fd43d97849ab8eadfcfc5fc95c17214..4729d7faa3341737820c3e336748e5dda8da7965 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.h
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.h
@@ -30,11 +30,10 @@ class IOBuffer;
class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
: public BidirectionalStreamImpl,
- public QuicChromiumClientStream::Delegate,
- public QuicChromiumClientSession::Observer {
+ public QuicChromiumClientStream::Delegate {
public:
explicit BidirectionalStreamQuicImpl(
- const base::WeakPtr<QuicChromiumClientSession>& session);
+ std::unique_ptr<QuicChromiumClientSession::Handle> session);
~BidirectionalStreamQuicImpl() override;
@@ -65,11 +64,6 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
void OnClose() override;
void OnError(int error) override;
- // QuicChromiumClientSession::Observer implementation:
- void OnCryptoHandshakeConfirmed() override;
- void OnSuccessfulVersionNegotiation(const QuicVersion& version) override;
- void OnSessionClosed(int error, bool port_migration_detected) override;
-
void OnStreamReady(int rv);
void OnSendDataComplete(int rv);
void OnReadDataComplete(int rv);
@@ -81,9 +75,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
// Resets the stream and ensures that |delegate_| won't be called back.
void ResetStream();
- base::WeakPtr<QuicChromiumClientSession> session_;
- bool was_handshake_confirmed_; // True if the crypto handshake succeeded.
- std::unique_ptr<QuicChromiumClientSession::StreamRequest> stream_request_;
+ const std::unique_ptr<QuicChromiumClientSession::Handle> session_;
QuicChromiumClientStream* stream_; // Non-owning.
const BidirectionalStreamRequestInfo* request_info_;
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698