Add a new QuicChromiumClientSession::Handle class

net/quic/chromium/bidirectional_stream_quic_impl.h

Index: net/quic/chromium/bidirectional_stream_quic_impl.h
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.h b/net/quic/chromium/bidirectional_stream_quic_impl.h
index 125658194fd43d97849ab8eadfcfc5fc95c17214..9b8cbee9792bf0366b4f860afd5e05178a8950b9 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.h
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.h
@@ -30,11 +30,10 @@ class IOBuffer;
 
 class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
     : public BidirectionalStreamImpl,
-      public QuicChromiumClientStream::Delegate,
-      public QuicChromiumClientSession::Observer {
+      public QuicChromiumClientStream::Delegate {
  public:
   explicit BidirectionalStreamQuicImpl(
-      const base::WeakPtr<QuicChromiumClientSession>& session);
+      std::unique_ptr<QuicChromiumClientSession::Handle> session);
 
   ~BidirectionalStreamQuicImpl() override;
 
@@ -65,11 +64,6 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
   void OnClose() override;
   void OnError(int error) override;
 
-  // QuicChromiumClientSession::Observer implementation:
-  void OnCryptoHandshakeConfirmed() override;
-  void OnSuccessfulVersionNegotiation(const QuicVersion& version) override;
-  void OnSessionClosed(int error, bool port_migration_detected) override;
-
   void OnStreamReady(int rv);
   void OnSendDataComplete(int rv);
   void OnReadDataComplete(int rv);
@@ -81,9 +75,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
   // Resets the stream and ensures that |delegate_| won't be called back.
   void ResetStream();
 
-  base::WeakPtr<QuicChromiumClientSession> session_;
-  bool was_handshake_confirmed_;  // True if the crypto handshake succeeded.
-  std::unique_ptr<QuicChromiumClientSession::StreamRequest> stream_request_;
+  std::unique_ptr<QuicChromiumClientSession::Handle> session_;

[xunjieli, 2017/05/05 14:10:01]

I guess this can be "const std::unique_ptr<>" ?

[Ryan Hamilton, 2017/05/05 17:32:47]

Done. (I don't think I've ever seen a const std::unique_ptr<> as a member
before)

[xunjieli, 2017/05/05 17:52:13]

https://cs.chromium.org/search/?q=const+std::unique_ptr+file:%5Esrc/net/+pack...
10 pages of result in net/ :)

[Ryan Hamilton, 2017/05/05 18:27:38]

Learn something new every day! :)

Though I think you need "s in your search, because that search matches lines
line:

static const SpdyStreamId kInvalidStream;

So with quotes we get:

https://cs.chromium.org/search/?q=%22const+std::unique_ptr%22+file:%5Esrc/net...

Which is 32 results. But still, more than I knew about! :)

   QuicChromiumClientStream* stream_;  // Non-owning.
 
   const BidirectionalStreamRequestInfo* request_info_;