Add a new QuicChromiumClientSession::Handle class

net/quic/chromium/bidirectional_stream_quic_impl.h

Index: net/quic/chromium/bidirectional_stream_quic_impl.h
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.h b/net/quic/chromium/bidirectional_stream_quic_impl.h
index 7723fafe2ae7c2c499581d90bde676dd5bf505ce..0e5d4d5e47ceda5ba5a8e042ea0c307cca703b6a 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.h
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.h
@@ -30,11 +30,10 @@ class IOBuffer;
 
 class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
     : public BidirectionalStreamImpl,
-      public QuicChromiumClientStream::Delegate,
-      public QuicChromiumClientSession::Observer {
+      public QuicChromiumClientStream::Delegate {
  public:
   explicit BidirectionalStreamQuicImpl(
-      const base::WeakPtr<QuicChromiumClientSession>& session);
+      QuicChromiumClientSession::Handle session);
 
   ~BidirectionalStreamQuicImpl() override;
 
@@ -66,11 +65,6 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
   void OnError(int error) override;
   bool HasSendHeadersComplete() override;
 
-  // QuicChromiumClientSession::Observer implementation:
-  void OnCryptoHandshakeConfirmed() override;
-  void OnSuccessfulVersionNegotiation(const QuicVersion& version) override;
-  void OnSessionClosed(int error, bool port_migration_detected) override;
-
   void OnStreamReady(int rv);
   void OnSendDataComplete(int rv);
   void OnReadDataComplete(int rv);
@@ -82,8 +76,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
   // Resets the stream and ensures that |delegate_| won't be called back.
   void ResetStream();
 
-  base::WeakPtr<QuicChromiumClientSession> session_;
-  bool was_handshake_confirmed_;  // True if the crypto handshake succeeded.
+  QuicChromiumClientSession::Handle session_;

[xunjieli, 2017/05/04 16:54:42]

nit: can this be a const member?

[Ryan Hamilton, 2017/05/05 03:50:24]

If it were const then I couldn't call non-const methods on it, right?

   std::unique_ptr<QuicChromiumClientSession::StreamRequest> stream_request_;
   QuicChromiumClientStream* stream_;  // Non-owning.