Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2334893002: Move some paint-related tests to NeverFixTests (Closed)

Created:
4 years, 3 months ago by Stephen Chennney
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some paint-related tests to NeverFixTests The moved tests are always expected to fail due to stack-space issues or incompatible test flags. Also update the comment as to what belongs in NeverFixTests. Two tests that were in NeverFixTests are just Slow now, so re-enable them. R=dpranke@chromium.org BUG=381840, 601669, 646528 Committed: https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947 Cr-Commit-Position: refs/heads/master@{#418862}

Patch Set 1 #

Patch Set 2 : Mark lots-of-img-layers LayoutTests as Slow #

Patch Set 3 : New baselines #

Patch Set 4 : Rebase #

Patch Set 5 : Trying to get correct baselines. #

Patch Set 6 : Broaden an expectation to all Win bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1423 lines, -2354 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 2 3 4 5 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/StaleTestExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.txt View 1 2 3 4 1 chunk +706 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.txt View 1 2 3 4 1 chunk +706 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-with-opacity-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-with-opacity-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-expected.txt View 1 2 3 4 1 chunk +0 lines, -468 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt View 1 2 3 4 1 chunk +0 lines, -468 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-expected.txt View 1 2 3 4 1 chunk +0 lines, -702 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-with-opacity-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-with-opacity-expected.txt View 1 2 3 4 1 chunk +0 lines, -702 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Stephen Chennney
dpranke, please take a look, mainly to verify if you're OK with the changes to ...
4 years, 3 months ago (2016-09-14 14:02:46 UTC) #5
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-14 17:26:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334893002/80001
4 years, 3 months ago (2016-09-15 00:53:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293518)
4 years, 3 months ago (2016-09-15 02:54:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334893002/100001
4 years, 3 months ago (2016-09-15 13:13:00 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-15 14:18:06 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:19:36 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947
Cr-Commit-Position: refs/heads/master@{#418862}

Powered by Google App Engine
This is Rietveld 408576698