Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2334873002: [LayoutNG] Don't implement ContainerSize() using the physical constraint space. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 676ad16d00ea592851e80e1fe1a56db102da2bf4..7db295ccd3fdb74db45613bc3c3b4a962968ceb9 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -32,7 +32,13 @@ NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
: physical_space_(constraint_space->PhysicalSpace()),
offset_(constraint_space->Offset()),
size_(constraint_space->Size()),
- writing_mode_(writing_mode) {}
+ writing_mode_(writing_mode) {
+ if (writing_mode != constraint_space->WritingMode()) {
+ // TODO(layout-ng): Need to convert offset_ too.
+ size_ = size_.ConvertToWritingMode(constraint_space->WritingMode(),
+ writing_mode);
+ }
+}
NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
const NGConstraintSpace& other,
@@ -83,11 +89,6 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(
return derived_constraint_space;
}
-NGLogicalSize NGConstraintSpace::ContainerSize() const {
- return physical_space_->container_size_.ConvertToLogical(
- static_cast<NGWritingMode>(writing_mode_));
-}
-
bool NGConstraintSpace::InlineTriggersScrollbar() const {
return writing_mode_ == HorizontalTopBottom
? physical_space_->width_direction_triggers_scrollbar_

Powered by Google App Engine
This is Rietveld 408576698