Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2334863002: Ignore overhead slices in cpu time computation. (Closed)

Created:
4 years, 3 months ago by erikchen
Modified:
4 years, 3 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Ignore overhead slices in cpu time computation. BUG=catapult:#

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tracing/tracing/metrics/system_health/cpu_time_metric.html View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
nednguyen
4 years, 3 months ago (2016-09-12 19:51:20 UTC) #2
Message was sent while issue was closed. 
On 2016/09/12 19:40:06, erikchen wrote:
> Description was changed from
> 
> ==========
> Ignore overhead slices in cpu time computation.
> 
> BUG=catapult:#
> ==========
> 
> to
> 
> ==========
> Ignore overhead slices in cpu time computation.
> 
> BUG=catapult:#
> ==========

Now I realize that the exact mechanism of computing the cpu time metrics is more
nuanced than I thought, I think we should consult with Tim Dresser (lead of
progressive web metrics) & Charlie (power-infra lead) on how we should construct
this metric

Powered by Google App Engine
This is Rietveld 408576698