third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2334803002: Implementation of media controls download button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2334803002: Implementation of media controls download button. (Closed)

Patch Set: --no-find-copies Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp ('K') | « third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index fb2ba808b243a56342dd927adf0f757ffd12a665..8c4808214bb7c454332013dca90f7f14dc3484b1 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -235,7 +235,7 @@ void MediaControls::initializeControls()

m_fullscreenButton = fullscreenButton;

panel->appendChild(fullscreenButton);

- MediaControlDownloadButtonElement* downloadButton = MediaControlDownloadButtonElement::create(*this, &document());

+ MediaControlDownloadButtonElement* downloadButton = MediaControlDownloadButtonElement::create(*this);

m_downloadButton = downloadButton;

panel->appendChild(downloadButton);

@@ -263,7 +263,7 @@ void MediaControls::initializeControls()

m_overflowList->appendChild(m_toggleClosedCaptionsButton->createOverflowElement(*this, MediaControlToggleClosedCaptionsButtonElement::create(*this)));

m_overflowList->appendChild(m_fullscreenButton->createOverflowElement(*this, MediaControlFullscreenButtonElement::create(*this)));

m_overflowList->appendChild(m_playButton->createOverflowElement(*this, MediaControlPlayButtonElement::create(*this)));

- m_overflowList->appendChild(m_downloadButton->createOverflowElement(*this, MediaControlDownloadButtonElement::create(*this, &document())));

+ m_overflowList->appendChild(m_downloadButton->createOverflowElement(*this, MediaControlDownloadButtonElement::create(*this)));

}

void MediaControls::reset()

@@ -307,8 +307,7 @@ void MediaControls::reset()

refreshCastButtonVisibilityWithoutUpdate();

- if (RuntimeEnabledFeatures::mediaControlsDownloadButtonEnabled())

- m_downloadButton->setIsWanted(m_downloadButton->shouldDisplayDownloadButton());

+ m_downloadButton->setIsWanted(m_downloadButton->shouldDisplayDownloadButton());

}

LayoutObject* MediaControls::layoutObjectForTextTrackLayout()