third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html - Issue 2334803002: Implementation of media controls download button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html

Issue 2334803002: Implementation of media controls download button. (Closed)

Patch Set: --no-find-copies Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media-expected.txt ('K') | « third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button-expected.txt ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.h » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html

index 430b5672c88ab7a5df7a02844b09dac408348170..9ea0cd2a6c844f0d0762718133d13f9f1eae4cef 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html

@@ -20,7 +20,6 @@ async_test(function(t) {

internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

video.onloadeddata = t.step_func_done(function() {

- window.internals.runtimeFlags.MediaControlsDownloadButton = true;

var overflowList = getOverflowList(video);

var children = overflowList.children;

// Ensure that all of the buttons are visible in the right order